chore: Enhance PopulateResourceFromAnnotation error message#582
Conversation
|
.retest |
|
/retest |
|
this is so much better @michaelhtm thanks! |
The error message returned from PopulateResourceFromAnnotation was not descriptive enough, as it did not include the name of the required field that was missing. This change is including the field name in the error message.
michaelhtm
force-pushed
the
chore/enhanceerrormessagepopulateresourcefromannotation
branch
from
fdf5294 to
488a555
Compare
|
/test dynamodb-controller-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow
bot
merged commit f0e8616
into
aws-controllers-k8s:main
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
Description of changes:
The error message returned from PopulateResourceFromAnnotation was
not descriptive enough, as it did not include the name of the required field
that was missing.
This change is including the field name in the error message.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.