Add support for custom shapes using simplified schema#574
Add support for custom shapes using simplified schema#574rushmash91 merged 3 commits intoaws-controllers-k8s:mainfrom
Conversation
rushmash91
changed the title
rushmash91
changed the title
|
/retest |
|
/test s3-controller-test |
rushmash91
force-pushed
the
simpleschema
branch
from
acb83c3 to
252cd20
Compare
rushmash91
force-pushed
the
simpleschema
branch
from
21915b0 to
82298d8
Compare
rushmash91
force-pushed
the
simpleschema
branch
from
82298d8 to
afd027d
Compare
rushmash91
force-pushed
the
simpleschema
branch
from
bfac339 to
05971ba
Compare
rushmash91
force-pushed
the
simpleschema
branch
from
05971ba to
31e0e59
Compare
a-hilaly
left a comment
a-hilaly
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot Arush!! Getting very close - a few minor comments:
pkg/testdata/models/apis/dynamodb/0000-00-00/generator-with-custom-shapes.yaml
Show resolved
Hide resolved
rushmash91
force-pushed
the
simpleschema
branch
from
238c905 to
f582110
Compare
a-hilaly
left a comment
a-hilaly
left a comment
There was a problem hiding this comment.
Awesome works on this @rushmash91 ! thanks a lot for the quick updates :)
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test eks-controller-test |
|
@rushmash91: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 participants
Description of changes:
CustomShapesfield to the Config struct to store user-defined custom shapesInjectSimpleSchemaShapesfunction that processes custom shapes and injects them into the SDK API modelgithub.zerozr99.workers.dev/kro-run/kropackage for schema handlingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.