feat: Add version.json schema precedence and bundled fallback - #4573
Merged
kddejong merged 5 commits intoJul 8, 2026
Merged
Conversation
- Schema manager checks package data dir first (bundled PyPI install), falls back to user cache dir when bundled schemas don't exist - update() always writes to cache dir and switches to reading from there - CD workflow copies schemas from cache into package dir for bundling
Compare schema_date between bundled and cached schemas to determine which to use. Cache wins if its schema_date is newer than bundled, enabling cfn-lint -u to take effect. A pip upgrade with newer bundled schemas will take precedence until user runs -u again. update() now also fetches version.json from the release and stores it in the cache directory alongside the schema data.
kddejong
force-pushed
the
fix/configurable-schema-cache-dir
branch
from
July 7, 2026 17:10
af2dcfe to
36218b4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4573 +/- ##
==========================================
+ Coverage 94.41% 94.42% +0.01%
==========================================
Files 429 429
Lines 15056 15097 +41
Branches 2911 2915 +4
==========================================
+ Hits 14215 14256 +41
Misses 461 461
Partials 380 380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema_datefromversion.jsonbetween bundled and cache to determine precedencecfn-lint -udownloads to cache and fetchesversion.json— cache wins if newer-uagainDepends on
version.jsonto release artifactsTest plan
cfn-lint -udownloads to cache, cache takes precedence after