Skip to content

Conversation

@snowiow
Copy link
Contributor

@snowiow snowiow commented Jan 30, 2023

Issue #109, if available:

Description of changes:
I executed ncc to package the actual state of the current code, because the changes made in this PR, aren't actually distributed in the action itself.

This PR also updates the ncc compiler, because the one by @zeit is deprecated. Now the suggested @vercel/ncc is used.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@taoyong-ty
Copy link
Contributor

The action-core functions have been updated in the distributable index.js by another recent PR

But I'd still want to merge the @vercel/ncc update in your change. Could you resolve the conflicts?

taoyong-ty
taoyong-ty previously approved these changes Jan 30, 2023
@snowiow
Copy link
Contributor Author

snowiow commented Jan 31, 2023

Yep, branch should be up to date again. Thanks!

@snowiow
Copy link
Contributor Author

snowiow commented Jan 31, 2023

The action-core functions have been updated in the distributable index.js by another recent #116

nice! can you create a new release with that change?

@taoyong-ty taoyong-ty merged commit bb79642 into aws-actions:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants