-
Notifications
You must be signed in to change notification settings - Fork 2
update to reflect change in offline branch #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
longshuicy
wants to merge
12
commits into
main
Choose a base branch
from
update-ray-w-offline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b85810d
update to reflect change in offline branch
longshuicy 93c63ba
fix wrong import
longshuicy 506a35c
fix the import
longshuicy 9330011
move_to_host needs to handle multiple input tile cases
longshuicy 72daa72
fix type checking issue
longshuicy 7535bb6
add capability to connect to remote ray cluster
longshuicy ef506a9
create datacube at the beginning of the pipeline
longshuicy a5bed24
adding pixi shell readme
tcnichol 4158d4d
update pixi shell
tcnichol d768795
Merge branch 'main' into update-ray-w-offline
longshuicy 365fa81
switch to actor; GPU set to 1 instead of a fraction; add more logs
longshuicy e262d4d
Dockerfile to build py312 image
longshuicy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,3 +49,5 @@ scripts-local/ | |
| # pixi environments | ||
| .pixi | ||
| *.egg-info | ||
| .idea/ | ||
| *.toml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| FROM rayproject/ray:nightly-py312-gpu | ||
|
|
||
| USER root | ||
|
|
||
| # Install uv | ||
| RUN curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| ENV PATH="/root/.local/bin:${PATH}" | ||
|
|
||
| # Create writable directory | ||
| WORKDIR /app | ||
|
|
||
| # Copy project | ||
| COPY . . | ||
|
|
||
| # Create venv + install deps | ||
| RUN uv venv --python 3.12 --clear && \ | ||
| . .venv/bin/activate && \ | ||
| uv sync --extra cuda126 | ||
|
|
||
| ENV VIRTUAL_ENV=/app/.venv | ||
| ENV PATH="/app/.venv/bin:${PATH}" | ||
|
|
||
| CMD ["ray", "start", "--head"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Pixi shell instructions | ||
|
|
||
| If you are unable to install the nvidia related dependencies directly, you will be | ||
| using a pixi shell. This requires a few extra steps before you can run the darts pipeline | ||
|
|
||
| First, run this command | ||
|
|
||
| `pixi shell -e cuda128` | ||
|
|
||
| `conda install -c nvidia cuda-toolkit=12 -y | ||
| ` | ||
|
|
||
| then | ||
|
|
||
| `uv sync --extra cuda128 --extra torchdeps --extra cuda12deps` | ||
|
|
||
| This will install the dependencies. | ||
|
|
||
| Once you run those, you will activate the environment using this command: | ||
|
|
||
| `source .venv/bin/activate` | ||
|
|
||
| commands are then run like this. Note that there is no `uv run` at the start. | ||
|
|
||
| `darts inference sentinel2-ray --aoi-shapefile | ||
| /taiga/toddn/rts-files/tiles_nwt_2010_2016_small.geojson | ||
| --start-date 2024-07 --max-cloud-cover 100 --max-snow-cover 100 | ||
| --end-date 2024-09 --verbose` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be problematic and causing the backpressure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was running into this issue
File "/Users/cwang138/Documents/Projects/PDG/darts-nextgen/darts-utils/src/darts_utils/cuda.py", line 67, in move_to_host
if tile.cupy.is_cupy:
^^^^^^^^^
File "/Users/cwang138/Documents/Projects/PDG/darts-nextgen/.venv/lib/python3.12/site-packages/xarray/core/common.py", line 306, in getattr
raise AttributeError(
AttributeError: 'Dataset' object has no attribute 'cupy'. Did you mean: 'copy'?
hence I added different safeguard
Tobias Hölzer
Nov 13th at 4:50 PM
Ah, maybe try to add "import cupy_xarray " in the function before calling tile.cupy...
🆗
1
4:50
https://github.com/xarray-contrib/cupy-xarray
xarray-contrib/cupy-xarray
Interface for using cupy in xarray, providing convenience accessors.
Website
https://cupy-xarray.readthedocs.io/
Stars
85
Added by GitHub
4:51
Seems like ray doesn't import this properly 😅