Remove usage of marshal_dump since this was removed from Rails#415
Open
edipofederle wants to merge 2 commits intoawesome-print:masterfrom
Open
Remove usage of marshal_dump since this was removed from Rails#415edipofederle wants to merge 2 commits intoawesome-print:masterfrom
edipofederle wants to merge 2 commits intoawesome-print:masterfrom
Conversation
edipofederle
force-pushed
the
fix-marshal-dump
branch
2 times, most recently
from
648ab3d to
5c9526e
Compare
edipofederle
force-pushed
the
fix-marshal-dump
branch
from
5c9526e to
2829fd0
Compare
|
Just caught this issue. Before this one is merged have to use monkeypatch from here: #413 (comment) |
Author
|
This is still relevant. Could someone with 'powers' take a look? thanks! |
|
ran into this today, would love if this PR was looked at so it can get fixed! Thanks @edipofederle |
|
Let's merge it, pretty please! 🥺 |
scouttyg
added a commit
to playboyenterprises/awesome_rails_console
that referenced
this pull request
Jun 9, 2022
…not to work under conditions like model.errors (see: awesome-print/awesome_print#415)
|
I ended up replacing awesome_print with a fork amazing_print which includes the fix https://github.com/amazing-print/amazing_print |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #413