fix: always call base class for HttpClient#352
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the source generator where HttpClient.Send methods were not always calling the base class implementation. The fix ensures that for HttpClient.Send* methods, the base class is always invoked regardless of mock setup, which is necessary for proper HttpClient functionality.
Key changes:
- Modified method generation logic to always call base class for
HttpClient.Send*methods - Restructured conditional logic to handle both void and non-void return types uniformly
|
🚀 Benchmark ResultsDetails
|
|
This is addressed in release v0.50.0. |



This PR fixes a bug in the source generator where
HttpClient.Sendmethods were not always calling the base class implementation. The fix ensures that forHttpClient.Send*methods, the base class is always invoked regardless of mock setup, which is necessary for properHttpClientfunctionality.Key changes:
HttpClient.Send*methods