You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes the execution order of OnlyOnce callbacks in the Mockolate mocking library. The issue was that callbacks configured with OnlyOnce() were being executed in reverse order due to an incorrect index increment operation.
Key changes
Removed premature index increment in Callback.Invoke method that was causing callbacks to execute in reverse order
Added comprehensive test to verify sequential execution of multiple OnlyOnce callbacks
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the execution order of OnlyOnce callbacks in the Mockolate mocking library. The issue was that callbacks configured with OnlyOnce() were being executed in reverse order due to an incorrect index increment operation.
Removed premature index increment in Callback.Invoke method that was causing callbacks to execute in reverse order
Added comprehensive test to verify sequential execution of multiple OnlyOnce callbacks
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File
Description
Source/Mockolate/Setup/Callback.cs
Removed Interlocked.Increment(ref index) call that was causing callbacks to execute in reverse order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the execution order of
OnlyOncecallbacks in the Mockolate mocking library. The issue was that callbacks configured withOnlyOnce()were being executed in reverse order due to an incorrect index increment operation.Key changes
Callback.Invokemethod that was causing callbacks to execute in reverse orderOnlyOncecallbacks