Better handling for Cursor by verifying stdin#644
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
✅ FlexReview StatusCommon Owner:
Review SLO: |
Summary of ChangesHello @jainankit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the terminal detection logic for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the handling of non-interactive sessions for the UI by adding a check to determine if stdin is a terminal. This is in addition to the existing check for stdout. This change prevents the application from hanging when used in a pipeline or other non-interactive environments. The implementation is correct and improves the overall robustness of the tool. I have no further suggestions.
The crash was caused by bubbletea's cancelreader trying to read from stdin when it wasn't a proper TTY. The original code only checked if stdout was a TTY, but in Cursor IDE's integrated terminal, stdout may appear as a TTY while stdin is not properly configured.
Now when either stdin or stdout is not a TTY, the program disables input handling with tea.WithInput(nil), preventing the nil pointer dereference in the cancelreader.