Skip to content

Better handling for Cursor by verifying stdin#644

Merged
aviator-app[bot] merged 2 commits intomasterfrom
aj/cursor-tty-chk
Jan 13, 2026
Merged

Better handling for Cursor by verifying stdin#644
aviator-app[bot] merged 2 commits intomasterfrom
aj/cursor-tty-chk

Conversation

@jainankit
Copy link
Copy Markdown
Contributor

@jainankit jainankit commented Jan 13, 2026

The crash was caused by bubbletea's cancelreader trying to read from stdin when it wasn't a proper TTY. The original code only checked if stdout was a TTY, but in Cursor IDE's integrated terminal, stdout may appear as a TTY while stdin is not properly configured.

Now when either stdin or stdout is not a TTY, the program disables input handling with tea.WithInput(nil), preventing the nil pointer dereference in the cancelreader.

@jainankit jainankit requested a review from a team as a code owner January 13, 2026 03:15
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Jan 13, 2026

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Jan 13, 2026

✅ FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

  • aviator-co/engineering (expert-load-balance assignment)
    Owned Files
    • 🔒 internal/utils/uiutils/tea.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.

@aviator-app aviator-app bot requested a review from davi-maciel January 13, 2026 03:16
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @jainankit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the terminal detection logic for BubbleTea applications to ensure more robust behavior in various execution contexts. By extending the check to include standard input, the system can more accurately identify when it's operating in a non-interactive environment, leading to better resource management and preventing unintended input handling.

Highlights

  • Improved Terminal Detection for BubbleTea: The RunBubbleTea function now checks both os.Stdin and os.Stdout to determine if the application is running in an interactive terminal. Previously, only os.Stdout was checked.
  • Enhanced Non-Interactive Handling: By verifying stdin in addition to stdout, BubbleTea applications will more reliably disable input when executed in non-interactive environments (e.g., when piped or redirected), preventing potential issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the handling of non-interactive sessions for the UI by adding a check to determine if stdin is a terminal. This is in addition to the existing check for stdout. This change prevents the application from hanging when used in a pipeline or other non-interactive environments. The implementation is correct and improves the overall robustness of the tool. I have no further suggestions.

@aviator-app aviator-app bot merged commit 4f517fb into master Jan 13, 2026
5 checks passed
@aviator-app aviator-app bot deleted the aj/cursor-tty-chk branch January 13, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants