Skip to content

Deprecate reference based metadata store#620

Closed
draftcode wants to merge 1 commit intomerged_branchfrom
deprecate_refmeta
Closed

Deprecate reference based metadata store#620
draftcode wants to merge 1 commit intomerged_branchfrom
deprecate_refmeta

Conversation

@draftcode
Copy link
Copy Markdown
Collaborator

It's been a while since we migrated to a file-base metadata storage. We
can drop this refmeta code.

It's been a while since we migrated to a file-base metadata storage. We
can drop this refmeta code.
@draftcode draftcode requested a review from a team as a code owner October 30, 2025 04:43
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Oct 30, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack

  1. 👉 Deprecate reference based metadata store #620 👈 (this pr)

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Oct 30, 2025

✅ FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

  • aviator-co/engineering (expert-load-balance assignment)
    Owned Files
    • 🔒 cmd/av/helpers.go
    • 🔒 internal/meta/refmeta/branch.go
    • 🔒 internal/meta/refmeta/import.go
    • 🔒 internal/meta/refmeta/repository.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.

@aviator-app aviator-app bot requested a review from simsinght October 30, 2025 04:43
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @draftcode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the deprecation of the reference-based metadata storage system by completely removing the refmeta package and all associated migration logic. The project has successfully transitioned to a file-based metadata storage, making the old system obsolete. This change simplifies the codebase, removes dead code, and cleans up dependencies related to the legacy metadata handling.

Highlights

  • Deprecation of refmeta package: The entire internal/meta/refmeta package, which was responsible for managing metadata stored directly within Git references, has been completely removed. This includes branch.go, import.go, and repository.go.
  • Simplified Metadata Initialization: The getOrCreateDB function in cmd/av/helpers.go has been streamlined. It no longer contains the legacy logic for migrating metadata from the old repo-metadata.json (reference-based) to the current av.db (file-based) system, directly opening the jsonfiledb.
  • Codebase Cleanup: Unused imports, specifically os (which was only needed for file system checks related to the old migration logic) and the refmeta package itself, have been removed from cmd/av/helpers.go.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the deprecated reference-based metadata store (refmeta). The changes are primarily deletions, which simplifies the codebase by removing the old migration logic from getOrCreateDB and the entire internal/meta/refmeta package. This is a good cleanup that improves maintainability. The changes are straightforward and correctly implement the goal of the pull request. I have no concerns with the proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants