Skip to content

JETAnalyzer: special case MethodErrorReport for [map]reduce_empty #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aviatesk merged 1 commit into from
May 18, 2023
Merged

JETAnalyzer: special case MethodErrorReport for [map]reduce_empty #518

aviatesk merged 1 commit into from
May 18, 2023

Conversation

@aviatesk
Copy link
Owner

@aviatesk aviatesk commented May 18, 2023

In the :basic mode, downgrade MethodErrorReport on call of reduce_empty or mapreduce_empty to UncaughtExceptionReport so that it can be filtered out in common cases.

xref: JuliaLang/julia#41885

@aviatesk
JETAnalyzer: special case MethodErrorReport for [map]reduce_empty
17ba0ef 
In the `:basic` mode, downgrade `MethodErrorReport` on call of
`reduce_empty` or `mapreduce_empty` to `UncaughtExceptionReport`
so that it can be filtered out in common cases.

xref: <JuliaLang/julia#41885>
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: -0.01 ⚠️

Comparison is base (739f3a9) 88.83% compared to head (17ba0ef) 88.82%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   88.83%   88.82%   -0.01%     
==========================================
  Files          10       10              
  Lines        2973     2989      +16     
==========================================
+ Hits         2641     2655      +14     
- Misses        332      334       +2
Impacted Files Coverage Δ
src/analyzers/jetanalyzer.jl 88.25% <91.66%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented May 18, 2023

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 18 May 2023 - 06:36
  • Baseline: 18 May 2023 - 06:50
  • Package commits:
  • Target: 8fcce3
  • Baseline: 739f3a
  • Julia commits:
  • Target: ce3909
  • Baseline: ce3909
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["JETAnalyzer{BasicPass} top-level", "self analysis"] 0.99 (5%) 0.95 (1%) ✅
["JETAnalyzer{BasicPass}", "identity(nothing)"] 0.84 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 1.08 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "rand(Bool)"] 1.10 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 0.92 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "identity(nothing)"] 0.76 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "rand(Bool)"] 1.10 (5%) ❌ 1.00 (1%)
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 1.38 (5%) ❌ 1.00 (1%)
["OptAnalyzer", "identity(nothing)"] 1.25 (5%) ❌ 1.00 (1%)
["OptAnalyzer", "println(QuoteNode(nothing))"] 1.06 (5%) ❌ 1.00 (1%)
["OptAnalyzer", "rand(Bool)"] 0.94 (5%) ✅ 1.00 (1%)
["OptAnalyzer", "sum(\"julia\")"] 0.91 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.0-DEV.1338
Commit ce3909cc8ce (2023-05-18 02:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1037-azure #44-Ubuntu SMP Thu Apr 20 13:19:31 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 4848 s 0 s 314 s 5220 s 0 s
 #2 2294 MHz 5879 s 0 s 269 s 4208 s 0 s
 Memory: 6.781208038330078 GB (4560.61328125 MB free)
 Uptime: 1048.78 sec
 Load Avg: 1.0 1.02 0.83
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.10.0-DEV.1338
Commit ce3909cc8ce (2023-05-18 02:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1037-azure #44-Ubuntu SMP Thu Apr 20 13:19:31 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 9544 s 0 s 382 s 8727 s 0 s
 #2 2294 MHz 9570 s 0 s 451 s 8609 s 0 s
 Memory: 6.781208038330078 GB (4485.33984375 MB free)
 Uptime: 1878.27 sec
 Load Avg: 1.0 1.01 0.97
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 18 May 2023 - 6:36
  • Package commit: 8fcce3
  • Julia commit: ce3909
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 228.584 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 670.404 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 362.310 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 52.237 ms (5%) 2.17 MiB (1%) 38274
["JETAnalyzer{BasicPass} top-level", "self analysis"] 16.666 s (5%) 1.635 s 1.08 GiB (1%) 19929058
["JETAnalyzer{BasicPass} top-level", "simple"] 12.984 ms (5%) 2.11 MiB (1%) 36465
["JETAnalyzer{BasicPass}", "identity(nothing)"] 87.905 μs (5%) 7.39 KiB (1%) 107
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 230.724 ms (5%) 37.88 MiB (1%) 709876
["JETAnalyzer{BasicPass}", "rand(Bool)"] 78.322 ms (5%) 14.68 MiB (1%) 268451
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 190.311 μs (5%) 17.34 KiB (1%) 230
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 10.657 ms (5%) 1.95 MiB (1%) 34180
["JETAnalyzer{SoundPass}", "identity(nothing)"] 78.905 μs (5%) 7.39 KiB (1%) 107
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 324.474 ms (5%) 41.305 ms 59.46 MiB (1%) 847444
["JETAnalyzer{SoundPass}", "rand(Bool)"] 91.830 ms (5%) 18.36 MiB (1%) 302981
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 295.117 μs (5%) 22.34 KiB (1%) 267
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 9.437 ms (5%) 2.06 MiB (1%) 36184
["OptAnalyzer", "identity(nothing)"] 153.409 μs (5%) 25.61 KiB (1%) 370
["OptAnalyzer", "println(QuoteNode(nothing))"] 745.513 ms (5%) 75.693 ms 198.98 MiB (1%) 2943660
["OptAnalyzer", "rand(Bool)"] 39.051 ms (5%) 13.70 MiB (1%) 203543
["OptAnalyzer", "sum(\"julia\") (cached)"] 319.718 μs (5%) 59.66 KiB (1%) 821
["OptAnalyzer", "sum(\"julia\")"] 18.843 ms (5%) 5.83 MiB (1%) 87412
["show(::IO, ::JETCallResult)", "report_call"] 1.360 ms (5%) 274.89 KiB (1%) 5080
["show(::IO, ::JETCallResult)", "report_opt"] 21.401 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1338
Commit ce3909cc8ce (2023-05-18 02:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1037-azure #44-Ubuntu SMP Thu Apr 20 13:19:31 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 4848 s 0 s 314 s 5220 s 0 s
 #2 2294 MHz 5879 s 0 s 269 s 4208 s 0 s
 Memory: 6.781208038330078 GB (4560.61328125 MB free)
 Uptime: 1048.78 sec
 Load Avg: 1.0 1.02 0.83
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 18 May 2023 - 6:50
  • Package commit: 739f3a
  • Julia commit: ce3909
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 231.517 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 698.341 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 363.323 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 52.095 ms (5%) 2.17 MiB (1%) 38274
["JETAnalyzer{BasicPass} top-level", "self analysis"] 16.881 s (5%) 1.505 s 1.13 GiB (1%) 20247428
["JETAnalyzer{BasicPass} top-level", "simple"] 12.689 ms (5%) 2.11 MiB (1%) 36465
["JETAnalyzer{BasicPass}", "identity(nothing)"] 104.706 μs (5%) 7.39 KiB (1%) 107
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 212.973 ms (5%) 37.88 MiB (1%) 709876
["JETAnalyzer{BasicPass}", "rand(Bool)"] 71.247 ms (5%) 14.61 MiB (1%) 268449
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 188.411 μs (5%) 17.34 KiB (1%) 230
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 11.604 ms (5%) 1.95 MiB (1%) 34179
["JETAnalyzer{SoundPass}", "identity(nothing)"] 103.906 μs (5%) 7.39 KiB (1%) 107
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 323.160 ms (5%) 42.405 ms 59.46 MiB (1%) 847444
["JETAnalyzer{SoundPass}", "rand(Bool)"] 83.341 ms (5%) 18.30 MiB (1%) 302979
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 214.012 μs (5%) 22.34 KiB (1%) 267
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 9.471 ms (5%) 2.06 MiB (1%) 36184
["OptAnalyzer", "identity(nothing)"] 123.107 μs (5%) 25.61 KiB (1%) 370
["OptAnalyzer", "println(QuoteNode(nothing))"] 701.479 ms (5%) 71.302 ms 198.98 MiB (1%) 2943660
["OptAnalyzer", "rand(Bool)"] 41.660 ms (5%) 13.70 MiB (1%) 203543
["OptAnalyzer", "sum(\"julia\") (cached)"] 326.619 μs (5%) 59.66 KiB (1%) 821
["OptAnalyzer", "sum(\"julia\")"] 20.726 ms (5%) 5.83 MiB (1%) 87412
["show(::IO, ::JETCallResult)", "report_call"] 1.333 ms (5%) 274.89 KiB (1%) 5080
["show(::IO, ::JETCallResult)", "report_opt"] 22.501 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1338
Commit ce3909cc8ce (2023-05-18 02:54 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1037-azure #44-Ubuntu SMP Thu Apr 20 13:19:31 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 9544 s 0 s 382 s 8727 s 0 s
 #2 2294 MHz 9570 s 0 s 451 s 8609 s 0 s
 Memory: 6.781208038330078 GB (4485.33984375 MB free)
 Uptime: 1878.27 sec
 Load Avg: 1.0 1.01 0.97
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU family: 6
Model: 79
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4589.64
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 512 KiB (2 instances)
L3 cache: 50 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit 3a5fcf0 into master May 18, 2023
@aviatesk aviatesk deleted the avi/empty-reduce branch June 5, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aviatesk @codecov-commenter