Merged
Conversation
added 2 commits
December 18, 2020 06:47
s3rvac
approved these changes
Dec 18, 2020
Member
s3rvac
left a comment
s3rvac
left a comment
There was a problem hiding this comment.
Thanks for the fix 👍 I have reviewed and tested the code, and both runtime and memory have dropped down (runtime to 3 seconds, memory to 300 MB).
The Linux build failure is unrelated to the present PR (a GitHub timeout). Other tests are passing, so I am going to merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #907.