Merged
Conversation
Contributor
fmiguelgarcia
left a comment
There was a problem hiding this comment.
Could you please check the node (from develop branch) and LC (from miguel/nalgebra_dep) compilation?
LC could be the issue because it integrates avail-core, avail-subxt and subxt.
Contributor
Author
|
Hey, for now, it's only on Avail-core, we'll update the node in the coming days, then check for compilation and versions. |
markopoloparadox
approved these changes
Aug 2, 2023
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 59.22% 58.13% -1.09%
==========================================
Files 55 54 -1
Lines 7521 7644 +123
==========================================
- Hits 4454 4444 -10
- Misses 3067 3200 +133
☔ View full report in Codecov by Sentry. |
fmiguelgarcia
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is not meant to be merged right now.
It need to be used to update our node and check for compatibility with node / LC.