This repository was archived by the owner on Dec 16, 2025. It is now read-only.
close database on shutdown #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
previously approved these changes
Dec 5, 2024
darioush
left a comment
darioush
left a comment
There was a problem hiding this comment.
Not: would slightly prefer the name vm.versiondb
Also IMO we should add a line in release notes
darioush
reviewed
Dec 10, 2024
darioush
approved these changes
Dec 10, 2024
darioush
pushed a commit
that referenced
this pull request
Jan 13, 2025
Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: Michael Kaplan <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Richard Pringle <[email protected]> Co-authored-by: Quentin McGaw <[email protected]> Co-authored-by: Meaghan FitzGerald <[email protected]> Co-authored-by: Quentin McGaw <[email protected]> Co-authored-by: mountcount <[email protected]> Co-authored-by: chuangjinglu <[email protected]> Co-authored-by: guqicun <[email protected]> Co-authored-by: Dmytrol <[email protected]> fix problematic const name and some typos in comment (#1400) fix some function names in interface comment (#1397) close database on shutdown (#1403) fix some function names in comment (#1405) Fix Typos in Documentation (#1404) fix test generator (#724)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It correctly handles database close on
ShutdownHow this works
vm.dbtovm.verdbvm.dbonShutdownNoSyncin pebbledbHow this was tested
Locally + devnet
Need to be documented?
No
Need to update RELEASES.md?
No