add validators pkg readme #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meaghanfitzgerald
requested changes
Nov 26, 2024
Collaborator
meaghanfitzgerald
left a comment
meaghanfitzgerald
left a comment
There was a problem hiding this comment.
Suggestions are mostly for phrasing and grammar. It would be helpful if the read pointed to the places in Subnet-EVM where these functions exist, and provide example curls (or point to the ones in the docs site).
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
meaghanfitzgerald
previously approved these changes
Nov 27, 2024
ARR4N
reviewed
Nov 28, 2024
Contributor
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
How much existing knowledge is a reader assumed to have? If non-negligible, where can they get that knowledge?
Collaborator
Author
I also captured AvalancheGo's uptime manager basics in that readme, so we don't assume any existing knowledge. LMK if anyhing is not clear or you think it requires additional context. |
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
darioush
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validators pkg readme