use nodeID filter and uptimePerc #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
getCurrentValidatorsin Platform VM API returns uptime percentage. This PR changes the uptime seconds to uptime percentage inGetCurrentValidatorsAPI to keep the consistency between APIs. It also adds NodeID filtering.How this works
plugin/evm/client.go: Modified theGetCurrentValidatorsmethod to acceptnodeIDsas a parameter, allowing for filtered queries. [1] [2]plugin/evm/service.go: IntroducedGetCurrentValidatorsRequestto handle node ID filtering and updated theGetCurrentValidatorsmethod to use this request. Additionally, changed theUptimefield toUptimePercentagefor consistency with the PlatformVM API. [1] [2] [3]Support for new method in state interfaces:
plugin/evm/validators/state/interfaces/state.go: AddedGetValidationIDmethod to theStateReaderinterface to retrieve validation IDs based on node IDs.plugin/evm/validators/state/state.go: Implemented theGetValidationIDmethod in thestatestruct to support the new functionality.How this was tested
Locally
Need to be documented?
Yes
Need to update RELEASES.md?
Not since we have not captured the API.