Uptime tracking api #1374
Merged
Uptime tracking api #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
…/subnet-evm into pausable-uptime-manager
…net-evm into uptime-tracking-api
michaelkaplan13
previously approved these changes
Nov 12, 2024
Contributor
michaelkaplan13
left a comment
michaelkaplan13
left a comment
There was a problem hiding this comment.
LGTM, only question is if there is an existing E2E test suite that we could add a new test case to in order to confirm the new /validators endpoints is working as expected in CI?
ceyonur
dismissed stale reviews from michaelkaplan13 and darioush
The base branch was changed.
michaelkaplan13
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds Validators API (GetCurrentValidators)
How this works
Refactors API (RPC) and Service files, adds new handler for
/validatorsendpoint and implementGetCurrentValidatorsAPIHow this was tested
Locally
How is this documented
Need to be documented