This repository was archived by the owner on Nov 25, 2025. It is now read-only.
chore(rawdb): migration to plugin/evm/rawdb #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/plugin/evm/rawdb
branch
from
737f723 to
1b96bd2
Compare
darioush
reviewed
Mar 5, 2025
qdm12
force-pushed
the
qdm12/plugin/evm/rawdb
branch
from
1b96bd2 to
432dfae
Compare
darioush
approved these changes
Mar 6, 2025
darioush
left a comment
darioush
left a comment
There was a problem hiding this comment.
If anyone has a better name than customrawdb that would be nice but I can't think of anything better right now
ARR4N
approved these changes
Mar 10, 2025
Collaborator
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
Minor comments re consistency, otherwise LGTM
qdm12
force-pushed
the
qdm12/plugin/evm/rawdb
branch
from
2d7b55b to
ba76d51
Compare
- Move our custom code from core/rawdb to plugin/evm/rawdb - Remove rawdb/imports.go and import from libevm directly in other files
- Use hyperlink config in comment
- Use constants when possible instead of variables
- Use `require` to shorten test
- Check errors returned
- Use t.Cleanup instead of defer
- Use `any` instead of `interface{}` like we're in Go 1.17 days!
qdm12
force-pushed
the
qdm12/plugin/evm/rawdb
branch
from
69e165e to
2773bbb
Compare
Contributor
Author
|
ℹ️ last force push is just to add missing gpg signatures (no diff) |
Contributor
Author
ARR4N
pushed a commit
that referenced
this pull request
Mar 11, 2025
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 19, 2025
See original PR ava-labs/coreth#851
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 21, 2025
See original PR ava-labs/coreth#851
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 21, 2025
See original PR ava-labs/coreth#851
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
See original PR ava-labs/coreth#851
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
See original PR ava-labs/coreth#851
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
See original PR ava-labs/coreth#851
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 28, 2025
See original PR ava-labs/coreth#851
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Apr 1, 2025
See original PR ava-labs/coreth#851
node-druidx56y
added a commit
to node-druidx56y/subnet-evm
that referenced
this pull request
Sep 28, 2025
See original PR ava-labs/coreth#851
kevpaq-520
added a commit
to kevpaq-520/subnet2
that referenced
this pull request
Oct 27, 2025
See original PR ava-labs/coreth#851
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Suggested by @darioush to clean up rawdb a bit further. This is non blocking for the libevm branch to be merged into master.
How this works
How this was tested
CI passing
Need to be documented?
No
Need to update RELEASES.md?
No