Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

Conversation

@darioush
Copy link

@darioush darioush commented Feb 17, 2025

Why this should be merged

Needed to match avalanchego

How this works

  1. Bumps go & avalanchego dependency
  2. Cherry-picks geth commit that fixes copyloopvar
  3. Fix copyloopvar in our code
  4. Align linters w/ upstream with a couple exceptions

How this was tested

CI

Need to be documented?

N/A

Need to update RELEASES.md?

Y

Darioush Jalali and others added 4 commits February 17, 2025 08:41
Changelog: https://golangci-lint.run/product/changelog/#1610

Removes `exportloopref` (no longer needed), replaces it with
`copyloopvar` which is basically the opposite.

Also adds:
- `durationcheck`
- `gocheckcompilerdirectives`
- `reassign`
- `mirror`
- `tenv`

---------

Co-authored-by: Marius van der Wijden <[email protected]>
@darioush darioush marked this pull request as ready for review February 17, 2025 17:45
@darioush darioush requested review from a team and ceyonur as code owners February 17, 2025 17:45
Co-authored-by: Quentin McGaw <[email protected]>
Signed-off-by: Darioush Jalali <[email protected]>
@darioush darioush enabled auto-merge (squash) February 17, 2025 18:54
@qdm12 qdm12 disabled auto-merge February 17, 2025 19:07
@darioush darioush merged commit 6060a4a into master Feb 17, 2025
8 checks passed
@darioush darioush deleted the bump-golang-1.23.6 branch February 17, 2025 19:28
qdm12 added a commit that referenced this pull request Feb 17, 2025
Co-authored-by: Martin HS <[email protected]>
Co-authored-by: Marius van der Wijden <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
darioush pushed a commit that referenced this pull request Feb 18, 2025
Co-authored-by: Martin HS <[email protected]>
Co-authored-by: Marius van der Wijden <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants