This repository was archived by the owner on Nov 25, 2025. It is now read-only.
fix panic if config duration is set to 0 #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
approved these changes
Jan 27, 2025
Contributor
|
missed it by that much :( |
joshua-kim
reviewed
Jan 27, 2025
| vm.builder = vm.NewBlockBuilder(vm.toEngine) | ||
| vm.builder.awaitSubmittedTxs() | ||
|
|
||
| var p2pValidators p2p.ValidatorSet = &validatorSet{} |
Contributor
There was a problem hiding this comment.
This will work but might leave confusing logs in DEBUG as we log when we drop messages because it's not a validator. An alternative would be to use p2p.NoOpHandler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids a panic if the node is not configured correctly.