Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

chore(core/types): Header libevm PostCopy hook (5) #759

Merged
merged 4 commits into from
Feb 25, 2025
Merged

chore(core/types): Header libevm PostCopy hook (5) #759

merged 4 commits into from
Feb 25, 2025

Conversation

@qdm12
Copy link
Contributor

@qdm12 qdm12 commented Jan 21, 2025 •
edited
Loading

  • Implement PostCopy header hook
  • Remove CopyHeader and use imported one from libevm

➡️ header copy hooks libevm PR

@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch 2 times, most recently from 88fa9e2 to bde7fb2 Compare January 21, 2025 16:15
@qdm12 qdm12 mentioned this pull request Jan 21, 2025
Merged
2 tasks
darioush
darioush previously approved these changes Jan 21, 2025
View reviewed changes
@qdm12 qdm12 marked this pull request as ready for review January 21, 2025 17:04
@qdm12 qdm12 requested review from a team and ceyonur as code owners January 21, 2025 17:04
@qdm12 qdm12 marked this pull request as draft January 21, 2025 17:05
qdm12
qdm12 commented Jan 21, 2025
View reviewed changes
qdm12
qdm12 commented Jan 21, 2025
View reviewed changes
@qdm12 qdm12 changed the title chore(core/types): header copy hooks chore(core/types): Header libevm Copy hook Jan 21, 2025
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch 2 times, most recently from da83d82 to 58f1171 Compare January 22, 2025 09:56
@qdm12 qdm12 mentioned this pull request Jan 22, 2025
Merged
@qdm12 qdm12 changed the title chore(core/types): Header libevm Copy hook chore(core/types): Header libevm PostCopy hook Feb 3, 2025
@qdm12 qdm12 mentioned this pull request Feb 10, 2025
Closed
@qdm12 qdm12 force-pushed the libevm-upstream-types branch 3 times, most recently from 0c98519 to 269fb9c Compare February 10, 2025 16:07
@qdm12 qdm12 changed the title chore(core/types): Header libevm PostCopy hook chore(core/types): Header libevm PostCopy hook Feb 10, 2025
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch 2 times, most recently from 3593f92 to 1daa313 Compare February 10, 2025 16:15
@qdm12 qdm12 changed the title chore(core/types): Header libevm PostCopy hook chore(core/types): Header libevm PostCopy hook (4) Feb 10, 2025
@qdm12 qdm12 force-pushed the libevm-upstream-types branch from 269fb9c to d98039c Compare February 10, 2025 16:21
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch from 1daa313 to 252114a Compare February 10, 2025 16:22
@qdm12 qdm12 force-pushed the libevm-upstream-types branch 3 times, most recently from 59ef836 to c6f5f69 Compare February 12, 2025 12:55
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch 2 times, most recently from da70431 to 3ff7dea Compare February 12, 2025 12:57
@qdm12 qdm12 requested a review from ARR4N February 21, 2025 17:12
ARR4N
ARR4N suggested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing status back to changes requested. See my response re keeping the tests.

Base automatically changed from libevm-upstream-types to libevm February 25, 2025 16:19
@qdm12 qdm12 dismissed darioush’s stale review February 25, 2025 16:19

The base branch was changed.

@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch from 3a78b42 to afe92cc Compare February 25, 2025 16:43
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch from afe92cc to 6b133ad Compare February 25, 2025 16:44
@qdm12 qdm12 marked this pull request as ready for review February 25, 2025 16:44
@qdm12 qdm12 requested review from ARR4N and darioush February 25, 2025 16:44
ARR4N
ARR4N approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all the things!

darioush
darioush approved these changes Feb 25, 2025
View reviewed changes
@qdm12 qdm12 merged commit 44a2447 into libevm Feb 25, 2025
6 checks passed
@qdm12 qdm12 deleted the qdm12/core/types/header-copy-hooks branch February 25, 2025 19:58
ARR4N added a commit that referenced this pull request Mar 10, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook (5) (#759)
ab612d2 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Mar 19, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
bf2cbe4 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Mar 21, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
678ec5b 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Mar 21, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
1a30d35 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
c996f8c 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
3de1bc8 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
e82c796 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Mar 28, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
317ac75 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
qdm12 added a commit to ava-labs/subnet-evm that referenced this pull request Apr 1, 2025
@qdm12 @ARR4N
chore(core/types): Header libevm PostCopy hook
5d6e078 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
@qdm12 qdm12 mentioned this pull request Apr 8, 2025
Merged
node-druidx56y added a commit to node-druidx56y/subnet-evm that referenced this pull request Sep 28, 2025
@node-druidx56y @ARR4N
chore(core/types): Header libevm PostCopy hook
b9d0fa5 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
kevpaq-520 added a commit to kevpaq-520/subnet2 that referenced this pull request Oct 27, 2025
@kevpaq-520 @ARR4N
chore(core/types): Header libevm PostCopy hook
131f7df 
- Implement `PostCopy` header hook
- Remove `CopyHeader` and use imported one from libevm

See original PR ava-labs/coreth#759

Signed-off-by: Quentin McGaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@ARR4N ARR4N ARR4N approved these changes

@darioush darioush darioush approved these changes

@ceyonur ceyonur ceyonur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qdm12 @ARR4N @darioush @ceyonur