This repository was archived by the owner on Nov 25, 2025. It is now read-only.
fix test generator #724
Merged
fix test generator #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Dec 30, 2024
darioush
left a comment
darioush
left a comment
There was a problem hiding this comment.
lgtm, would you please submit the upstream PR as well?
qdm12
approved these changes
Dec 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes the flaky test generator
How this works
This pull request includes a change to the
generatefunction in thetriedb/pathdb/database_test.gofile. The modification ensures that thecreateAccountOpoperation is always selected for the first iteration, and a random operation is chosen for subsequent iterations.triedb/pathdb/database_test.go: Modified thegeneratefunction to always selectcreateAccountOpfor the first iteration and randomize the operation for subsequent iterations.How this was tested
It's fix to the test
Need to be documented?
No
Need to update RELEASES.md?
No