This repository was archived by the owner on Nov 25, 2025. It is now read-only.
refactor(test): replace custom test context helper with standard context pattern #1417
+11
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext pattern Remove NewTestContext helper function from utilstest package and replace all usages with the standard context.WithCancel(t.Context()) pattern. This simplifies test code by using the built-in testing.T context directly instead of wrapping it with custom timeout/deadline logic. resolves #1412 Signed-off-by: Tsvetan Dimitrov ([email protected])
ceyonur
approved these changes
Nov 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
Remove
NewTestContexthelper function fromutilstestpackage and replace all usages with the standardcontext.WithCancel(t.Context())pattern.This simplifies test code by using the built-in
testing.Tcontext directly instead of wrapping it with custom timeout/deadline logic.How this was tested
existing UT
Need to be documented?
no
Need to update RELEASES.md?
no
resolves #1412
Signed-off-by: Tsvetan Dimitrov ([email protected])