DO NOT MERGE: diagnose firewood stack corruption

.github/workflows/coreth-ci.yml

@@ -35,6 +35,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/setup-go-for-project
+      - run: go install golang.org/x/tools/cmd/bisect@latest
       - run: ./scripts/run_task.sh build-test
       - run: ./scripts/run_task.sh coverage
 

.github/workflows/subnet-evm-ci.yml

@@ -36,6 +36,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/setup-go-for-project
+      - run: go install golang.org/x/tools/cmd/bisect@latest
       - run: ./scripts/run_task.sh build-test
       - run: ./scripts/run_task.sh coverage
 

graft/coreth/core/blockchain_test.go

@@ -736,11 +736,6 @@ func TestCanonicalHashMarker(t *testing.T) {
 }
 
 func testCanonicalHashMarker(t *testing.T, scheme string) {
-	// TODO: https://github.com/ava-labs/firewood/issues/1679
-	if scheme == customrawdb.FirewoodScheme {
-		t.Skip("firewood currently fails due to a stack corruption issue")
-	}
-
 	var cases = []struct {
 		forkA int
 		forkB int

graft/coreth/core/main_test.go

@@ -25,7 +25,7 @@ func TestMain(m *testing.M) {
 	params.RegisterExtras()
 
 	// May of these tests are likely to fail due to `log.Crit` in goroutines.
-	log.SetDefault(log.NewLogger(log.NewTerminalHandlerWithLevel(os.Stderr, log.LevelCrit, true)))
+	log.SetDefault(log.NewLogger(log.NewTerminalHandlerWithLevel(os.Stderr, log.LevelError, true)))
 
 	opts := []goleak.Option{
 		// No good way to shut down these goroutines:

graft/coreth/scripts/build_test.sh

@@ -16,4 +16,4 @@ fi
 
 cd "$REPO_ROOT/graft/coreth"
 # shellcheck disable=SC2046
-go test -shuffle=on ${race:-} -timeout="${TIMEOUT:-900s}" -coverprofile=coverage.out -covermode=atomic "$@" $(go list .//... | grep -v github.com/ava-labs/avalanchego/graft/coreth/tests)
+go test -shuffle=on ${race:-} -timeout="${TIMEOUT:-900s}" -coverprofile=coverage.out -covermode=atomic "$@" github.com/ava-labs/avalanchego/graft/coreth/core 

graft/evm/firewood/triedb.go

@@ -9,6 +9,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"runtime"
 	"sync"
 	"time"
 
@@ -268,6 +269,7 @@ func (t *TrieDB) Close() error {
 	t.possible = nil
 
 	// We must provide a context to close since it may hang while waiting for the finalizers to complete.
+	runtime.GC()
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
 	defer cancel()
 	return t.Firewood.Close(ctx)

graft/subnet-evm/core/blockchain_test.go

@@ -688,10 +688,6 @@ func TestCanonicalHashMarker(t *testing.T) {
 
 func testCanonicalHashMarker(t *testing.T, scheme string) {
 	// TODO: https://github.com/ava-labs/firewood/issues/1679
-	if scheme == customrawdb.FirewoodScheme {
-		t.Skip("firewood currently fails due to a stack corruption issue")
-	}
-
 	cases := []struct {
 		forkA int
 		forkB int

graft/subnet-evm/core/main_test.go

@@ -23,7 +23,7 @@ func TestMain(m *testing.M) {
 	params.RegisterExtras()
 
 	// May of these tests are likely to fail due to `log.Crit` in goroutines.
-	log.SetDefault(log.NewLogger(log.NewTerminalHandlerWithLevel(os.Stderr, log.LevelCrit, true)))
+	log.SetDefault(log.NewLogger(log.NewTerminalHandlerWithLevel(os.Stderr, log.LevelError, true)))
 
 	opts := []goleak.Option{
 		// No good way to shut down these goroutines:

graft/subnet-evm/scripts/build_test.sh

@@ -16,4 +16,4 @@ fi
 
 cd "$REPO_ROOT/graft/subnet-evm"
 # shellcheck disable=SC2046
-go test -shuffle=on ${race:-} -timeout="${TIMEOUT:-900s}" -coverprofile=coverage.out -covermode=atomic "$@" $(go list .//... | grep -v github.com/ava-labs/avalanchego/graft/subnet-evm/tests)
+go test -shuffle=on ${race:-} -timeout="${TIMEOUT:-900s}" -coverprofile=coverage.out -covermode=atomic "$@" github.com/ava-labs/avalanchego/graft/subnet-evm/core