Clean up UTXOs #1376
Closed
Clean up UTXOs #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested changes
Apr 18, 2023
vms/avm/states/state.go
Outdated
| return txIDs, nil | ||
| } | ||
|
|
||
| func (s *state) RemoveRejectedTxs() error { |
Contributor
There was a problem hiding this comment.
What we need to do in this PR:
- All statuses should be removed from the database. This includes Accepted, Rejected, and Processing statuses.
- All transactions with statuses Rejected or Processing must be removed from the database.
- All transactions with status Accepted must have all the UTXOs consumed removed from the database.
- Depending on the performance - we may need to batch these operations and perform them in the background.
|
|
||
| func (s *state) rejectedTxs() ([]ids.ID, error) { | ||
| var txIDs []ids.ID | ||
| iter := s.statusDB.NewIterator() |
Contributor
There was a problem hiding this comment.
creating an iterator pins a database version on disk all iterators must be Released.
vms/avm/states/state.go
Outdated
| return err | ||
| } | ||
| // find UTXOID produced by the tx | ||
| utxos := tx.UTXOs() |
Contributor
There was a problem hiding this comment.
We should not be touching produced UTXOs.
coffeeavax
force-pushed
the
txStatus
branch
2 times, most recently
from
41824d2 to
fa296bd
Compare
joshua-kim
pushed a commit
to joshua-kim/avalanchego
that referenced
this pull request
Apr 28, 2023
Merged
maru-ava
pushed a commit
to maru-ava/avalanchego
that referenced
this pull request
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested