Skip to content

Silence a harmless warning about a new FromSwarm event type#3477

Merged
teor2345 merged 2 commits intomainfrom
silence-swarm-warning
Apr 7, 2025
Merged

Silence a harmless warning about a new FromSwarm event type#3477
teor2345 merged 2 commits intomainfrom
silence-swarm-warning

Conversation

@teor2345
Copy link
Copy Markdown
Contributor

@teor2345 teor2345 commented Apr 7, 2025

Our previous upgrade of polkadot-sdk missed a new event type, which leads to repeated (but harmless) warnings.

This PR upgrades to the latest commit in autonomys/polkadot-sdk#27 to silence that warning.

It also disables an unstable test on Windows:
https://github.com/autonomys/subspace/actions/runs/14298799924/job/40069685954?pr=3477#step:11:1219

Code contributor checklist:

@teor2345 teor2345 added networking Subspace networking (DSN) nice-to-have Non-critical but nice to have labels Apr 7, 2025
@teor2345 teor2345 self-assigned this Apr 7, 2025
@teor2345 teor2345 requested a review from nazar-pc as a code owner April 7, 2025 01:24
@teor2345 teor2345 enabled auto-merge April 7, 2025 01:24
@nazar-pc
Copy link
Copy Markdown
Member

nazar-pc commented Apr 7, 2025

This repository is supposed to only ever use subspace-vX version of the code from our Substrate fork. Looks like we've being using a version that isn't even merged into subspace-v9 yet, now updating to yet another revision.

Please don't do this. Things should be reviewed and merged into subspace-vX of the fork first to make sure they are stable references and never change in the future.

@nazar-pc nazar-pc requested review from NingLin-P and vedhavyas April 7, 2025 01:32
@teor2345
Copy link
Copy Markdown
Contributor Author

teor2345 commented Apr 7, 2025

This repository is supposed to only ever use subspace-vX version of the code from our Substrate fork. Looks like we've being using a version that isn't even merged into subspace-v9 yet, now updating to yet another revision.

Please don't do this. Things should be reviewed and merged into subspace-vX of the fork first to make sure they are stable references and never change in the future.

Sorry about that, I'd talked with the team about it, and I was told it was ok. Happy to hold this change until we've reviewed and merged autonomys/polkadot-sdk#27 in our fork.

@teor2345 teor2345 force-pushed the silence-swarm-warning branch from 1c66c93 to 72c6c5b Compare April 7, 2025 08:47
@teor2345 teor2345 mentioned this pull request Apr 7, 2025
1 task
vedhavyas
vedhavyas previously approved these changes Apr 7, 2025
@vedhavyas vedhavyas force-pushed the silence-swarm-warning branch from 3405ca8 to f564312 Compare April 7, 2025 12:32
@teor2345 teor2345 added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 58346e8 Apr 7, 2025
10 checks passed
@teor2345 teor2345 deleted the silence-swarm-warning branch April 7, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

networking Subspace networking (DSN) nice-to-have Non-critical but nice to have

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants