Domain chain network stack updates#2999
Merged
shamil-gadelshin merged 8 commits intomainfrom Sep 10, 2024
Merged
Conversation
- add last_confirmed_domain_block_receipt method
shamil-gadelshin
requested review from
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
1 task
- add network handler for custon request-response protocol - add get `get_last_confirmed_domain_block_receipt` function to obtain remote domain data
shamil-gadelshin
force-pushed
the
domain-networking-updates
branch
from
64041cc to
2796912
Compare
teor2345
reviewed
Sep 3, 2024
Contributor
teor2345
left a comment
teor2345
left a comment
There was a problem hiding this comment.
Looks good to me, but I'm not familiar enough to approve. Has a minor rustfmt issue.
NingLin-P
reviewed
Sep 4, 2024
Contributor
NingLin-P
left a comment
NingLin-P
left a comment
There was a problem hiding this comment.
Make sense in general, left a few nits.
| tx_handler_controller, | ||
| network_starter, | ||
| sync_service, | ||
| _block_downloader, |
Contributor
There was a problem hiding this comment.
Seems _block_downloader is not used, not sure why made this change.
Contributor
Author
There was a problem hiding this comment.
block_downloader is exported for the future usage. I will get a domain block body and header to import already downloaded state for the last confirmed domain block.
teor2345
reviewed
Sep 8, 2024
NingLin-P
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares the domain networking stack for domain snap-sync.
Changes:
pause_syncvariable totrueon domain network initialization. We don't rely on Substrate sync in domain network.Code contributor checklist: