Conversation
nazar-pc
requested review from
NingLin-P,
rg3l3dr and
vedhavyas
as code owners
shamil-gadelshin
left a comment
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Do you mind adding context?
|
Context is basically in the second commit, PR description and partly in paritytech/polkadot-sdk#5364 mentioned in TODO We don't need Substrate's prometheus server, we don't want its RPC server in some cases and we also don't want |
shamil-gadelshin
left a comment
shamil-gadelshin
left a comment
There was a problem hiding this comment.
A small refactoring request - otherwise looks OK.
crates/subspace-service/src/lib.rs
Outdated
| mod metrics; | ||
| pub(crate) mod mmr; | ||
| pub mod rpc; | ||
| mod spawn_tasks; |
There was a problem hiding this comment.
Consider changing to task_spawner: spawn_tasks::spawn_tasks looks awkward.
There was a problem hiding this comment.
Renamed, though it is really a bad name in Substrate, I wouldn't call that function spawn_tasks in the first place.
|
One more thing: this finally allows us to customize informer, which we'll extend to show Subspace networking stats in addition to Substrate networking as well as various DSN sync stages, etc. |
2 participants
Finally we can do this.
Still can't remove
sp-sessiondependency due to RPC layer requiring it (alongside with keystore which consensus chain doesn't have), I'm still thinking what to do about it without copy-pasting a bunch of non-trivial boilerplate.Code contributor checklist: