Conversation
vedhavyas
reviewed
Sep 28, 2023
| use tokio::sync::Semaphore; | ||
|
|
||
| /// This corresponds to default value of `--max-runtime-instances` in Substrate | ||
| const BLOCKS_LIST_CHECK_CONCURRENCY: usize = 8; |
Contributor
There was a problem hiding this comment.
maybe MAX_CONCURRENT_BLOCK_VERIFICATIONS?
Member
Author
There was a problem hiding this comment.
Not really, the verification is running at higher concurrency, this is just for block list check that requires runtime API calls and is bound by number of runtime instances.
nazar-pc
force-pushed
the
parallel-block-verification
branch
from
2fe88f1 to
f88895e
Compare
nazar-pc
force-pushed
the
parallel-block-verification
branch
from
f88895e to
4e3a58d
Compare
vedhavyas
approved these changes
Sep 29, 2023
vanhauser-thc
added
audited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Substrate was upgraded in #2010 and parallel block verification is available (though upstream PR paritytech/polkadot-sdk#1598 is stuck), this PR takes advantage of it while accounting for two edge-cases: equivocation and runtime API call concurrency.
Code contributor checklist: