Conversation
nazar-pc
left a comment
There was a problem hiding this comment.
Makes sense, could you explain to me what that pending things is in general, is it something Ethereum-specific? It wasn't there before, so I'm wondering what is going on and why it is necessary.
We had to introduce Inherent data providers since upstream introduced `pending` tags for Eth rpc calls. When an rpc call with pending tag is received, we construct pending block by building a new block with extrinsics from tx pool. So they use inherent data providers to provide inherent data. For now, we just provide timestamp since that is always required. I have added an TODO to handle any new inherents that needs to be present. Ex runtime upgrade can be added in later PR
371c42b to
a7c09c6
Compare
This is ethereum read state rpc specific. More on the that here - https://ethereum.org/en/developers/docs/apis/json-rpc/#default-block. |
|
Hm, but we are not really building blocks on EVM domain in tranditional sense. How is it used then? Just curious, I see that it is basically required for correct RPC implementation. |
We had to introduce Inherent data providers since upstream introduced
pendingtags for Eth rpc calls. When an rpc call with pending tag is received, we construct pending block by building a new block with extrinsics from tx pool. So they use inherent data providers to provide inherent data. For now, we just provide timestamp since that is always required. I have added an TODO to handle any new inherents that needs to be present. Ex runtime upgrade can be added in later PRCode contributor checklist: