Merged
Conversation
543b100 to
84b12ce
Compare
84b12ce to
04d26bf
Compare
Member
Author
|
No one reviewed this yet, so I rebased it on |
shamil-gadelshin
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that verification in #1918 is done in its initial form things start moving a bit faster.
First commit adds support for node restart, we just initialize timekeeper from the last known block on restart. There is no point in doing anything fancier since node is likely way behind anyway.
Second commit refactors old gossip code to work with input/output streams instead, extends
PotSourceto follow block import (such that even if timekeeper is not enabled and we don't get gossip, we still update local state). This commit also made Timekeeper respect the boolean flag (previously was running unconditionally).There are still many issues and potential improvements around gossip, Timekeeper reset is not yet supported, but most of these things have TODOs in the code now, so can be followed from there.
Last commit removed old timekeeper and state management code as it became clear they will not be necessary.
Next steps:
I may also do some cleanups, refactoring and smaller things in the meantime as well, will see if I get stuck somewhere.
Code contributor checklist: