Skip to content

Basic PoT gossip#1922

Merged
nazar-pc merged 4 commits intomainfrom
basic-pot-gossip
Sep 6, 2023
Merged

Basic PoT gossip#1922
nazar-pc merged 4 commits intomainfrom
basic-pot-gossip

Conversation

@nazar-pc
Copy link
Copy Markdown
Member

@nazar-pc nazar-pc commented Sep 3, 2023

Now that verification in #1918 is done in its initial form things start moving a bit faster.

First commit adds support for node restart, we just initialize timekeeper from the last known block on restart. There is no point in doing anything fancier since node is likely way behind anyway.

Second commit refactors old gossip code to work with input/output streams instead, extends PotSource to follow block import (such that even if timekeeper is not enabled and we don't get gossip, we still update local state). This commit also made Timekeeper respect the boolean flag (previously was running unconditionally).

There are still many issues and potential improvements around gossip, Timekeeper reset is not yet supported, but most of these things have TODOs in the code now, so can be followed from there.

Last commit removed old timekeeper and state management code as it became clear they will not be necessary.

Next steps:

  • add support for timekeeper reset (and generally be prepare it to support entropy injection and slot iterations adjustment)
  • add entropy injection

I may also do some cleanups, refactoring and smaller things in the meantime as well, will see if I get stuck somewhere.

Code contributor checklist:

@nazar-pc nazar-pc requested a review from rg3l3dr as a code owner September 3, 2023 04:10
@nazar-pc nazar-pc mentioned this pull request Sep 4, 2023
1 task
Base automatically changed from basic-pot-verification to main September 4, 2023 15:26
@nazar-pc
Copy link
Copy Markdown
Member Author

nazar-pc commented Sep 5, 2023

No one reviewed this yet, so I rebased it on main

@nazar-pc nazar-pc mentioned this pull request Sep 5, 2023
1 task
@nazar-pc nazar-pc merged commit 17225c4 into main Sep 6, 2023
@nazar-pc nazar-pc deleted the basic-pot-gossip branch September 6, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants