Make ballast in genesis block pseudo-random rather than filled with zeroes#1620
Merged
Make ballast in genesis block pseudo-random rather than filled with zeroes#1620
Conversation
dariolina
previously approved these changes
Jun 29, 2023
liuchengxu
previously approved these changes
Jun 29, 2023
Contributor
liuchengxu
left a comment
liuchengxu
left a comment
There was a problem hiding this comment.
This is sort of a relief to me (the added boilerplate brings in some actual value finally :P)
nazar-pc
force-pushed
the
non-zero-ballast-at-genesis
branch
from
6d46af6 to
56bfb20
Compare
liuchengxu
previously approved these changes
Jun 29, 2023
…enesis # Conflicts: # crates/subspace-service/Cargo.toml
ParthDesai
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 30, 2023
0xjeremyfrank
pushed a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed this in the past. Drawbacks of zeroes include similar pieces and commitments in the very first sector, making it pseudo-random is much better.
Code contributor checklist: