Louquinze development #1578
Merged
Louquinze development #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Louquinze-development
eddiebergman
approved these changes
Aug 31, 2022
Contributor
eddiebergman
left a comment
eddiebergman
left a comment
There was a problem hiding this comment.
Looks mostly good as far as I can tell, I didn't read the test file.
One small nitpick about a comment that has an assumption which could just as well be an assert, but otherwise looks good and mostly the same.
I'll have a quick look commit by commit as well just to make it easier
autosklearn/pipeline/components/data_preprocessing/text_encoding/tfidf_encoding.py
Show resolved
Hide resolved
autosklearn/pipeline/components/data_preprocessing/text_encoding/tfidf_encoding.py
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## development #1578 +/- ##
===============================================
+ Coverage 84.68% 84.71% +0.02%
===============================================
Files 157 155 -2
Lines 11981 11898 -83
Branches 2066 2058 -8
===============================================
- Hits 10146 10079 -67
+ Misses 1284 1268 -16
Partials 551 551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1575