Conversation
|
This PR supersedes #1300. |
alistairjevans
left a comment
There was a problem hiding this comment.
Only 1 real thing that should change, that's the !(not null) check which can be simplified. The rest are mostly just thoughts, options, etc.
I'll try not to take the British English spelling removal too personally... 😂
src/Autofac/Core/Resolving/Pipeline/PipelineBuilderEnumerator.cs
Outdated
Show resolved
Hide resolved
test/Autofac.Specification.Test/Util/AsyncOnlyDisposeTracker.cs
Outdated
Show resolved
Hide resolved
test/Autofac.Test/Core/Activators/ProvidedInstance/ProvidedInstanceActivatorTests.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #1306 +/- ##
===========================================
+ Coverage 76.57% 76.83% +0.25%
===========================================
Files 188 188
Lines 5183 5180 -3
Branches 1062 1061 -1
===========================================
+ Hits 3969 3980 +11
+ Misses 714 702 -12
+ Partials 500 498 -2
Continue to review full report at Codecov.
|
|
The British English changes were either...
I mean, you pick. Either way is cool 😉 |
|
@alistairjevans or @tillig , When do you plan to publish Nuget package? |
|
@maulik-modi Is there something here that your code requires? The existing package should work perfectly well with .NET 6. |
|
.net 6 being major version, may be breaking changes requiring new version of autofac.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Travis Illig ***@***.***>
Sent: Monday, March 7, 2022 8:43:21 PM
To: autofac/Autofac ***@***.***>
Cc: Maulik Modi ***@***.***>; Mention ***@***.***>
Subject: Re: [autofac/Autofac] .NET 6 Support (PR #1306)
@maulik-modi<https://github.com/maulik-modi> Is there something here that your code requires? The existing package should work perfectly well with .NET 6.
—
Reply to this email directly, view it on GitHub<#1306 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIKLBXXO5VRUU3HNPEYZCU3U6YMJDANCNFSM5PFANIRQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
There's are no breaking changes. Instead of guessing, try it out and let us know if there's something you find not working. |
Includes:
net6.0TFM to all projects.newoperator to simplify object creation.x is not yinstead of!(x is y),x is not nullinstead ofx is object.staticthat don't access instance data (really only in test fixtures).A future PR can do some cleanup like setting up
ImplicitUsingsand file-scoped namespaces.