Owned<T> asynchronous disposal inconsistency with ILifetimeScope

[rafalkwol]

It seems that if you call DisposeAsync on instance of Owned all the dependant instances under that scope still get disposed with Dispose method instead of DisposeAsync when it's available.

[alistairjevans]

Thanks @rafalkwol; taking a look at the code of Owned<T>, it's pretty clear there was a miss there.

We need to add an override of DisposeAsync in Owned and the associated tests.

Any interest in raising a PR?

[rafalkwol]

@alistairjevans I'm not that well well-versed with GitHub and I use git in work only on a really small scale so I'm not really sure what raising a PR means. I'm guessing it's about creating a pull request to fix the issue that will later be merged to main branch? Sorry for this question. I never really participated in contribution to some public projects on GitHub so I'm not sure what the rules and etiquette are.

[alistairjevans]

No need to apologise; you've got it right. Very briefly, you can fork this repository, make your changes in your fork, and then raise a pull request to bring the changes from your repo into this one (at which point we can review it).

Have a read of our Contributing Guide, which may guide you in making the changes.

If you don't feel comfortable with that though, no pressure, it just might take slightly longer to fix.

[rafalkwol]

@alistairjevans Thanks for explanation. I will try to look into it on the weekend and will see if it's up to my abilities.