Skip to content

Fix: id field in SignUpResponse#1190

Merged
tusharpandey13 merged 3 commits intomasterfrom
fix-991-GH-issue
Sep 23, 2025
Merged

Fix: id field in SignUpResponse#1190
tusharpandey13 merged 3 commits intomasterfrom
fix-991-GH-issue

Conversation

@tanya732
Copy link
Contributor

@tanya732 tanya732 commented Sep 18, 2025

This PR addresses inconsistency in the SignUpResponse object by ensuring the id field is always available, regardless of which identifier field the Auth0 API returns i.e., _id, user_id or id

fixes #991

This inconsistency caused issues for developers.

@tanya732 tanya732 requested a review from a team as a code owner September 18, 2025 05:14
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.20%. Comparing base (3fda381) to head (d1fd7ed).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1190    +/-   ##
========================================
  Coverage   79.19%   79.20%            
========================================
  Files         580      580            
  Lines       18150    18155     +5     
  Branches     8480     8617   +137     
========================================
+ Hits        14374    14379     +5     
  Misses       3776     3776            
Flag Coverage Δ
alltests 79.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tusharpandey13 tusharpandey13 merged commit c827069 into master Sep 23, 2025
14 checks passed
@tusharpandey13 tusharpandey13 deleted the fix-991-GH-issue branch September 23, 2025 15:49
@developerkunal developerkunal mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data returned from signUp mismatches SignUpResponse

3 participants