Fix: id field in SignUpResponse#1190
Merged
tusharpandey13 merged 3 commits intomasterfrom Sep 23, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
========================================
Coverage 79.19% 79.20%
========================================
Files 580 580
Lines 18150 18155 +5
Branches 8480 8617 +137
========================================
+ Hits 14374 14379 +5
Misses 3776 3776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kushalshit27
approved these changes
Sep 23, 2025
tusharpandey13
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses inconsistency in the SignUpResponse object by ensuring the id field is always available, regardless of which identifier field the Auth0 API returns i.e., _id, user_id or id
fixes #991
This inconsistency caused issues for developers.