UPSTREAM PR #18374: llama_fit_params: return enum for fail vs. error#705
Open
UPSTREAM PR #18374: llama_fit_params: return enum for fail vs. error#705
Conversation
loci-dev
temporarily deployed
to
PROD__AL_DEMO
GitHub Actions
Inactive
loci-dev
force-pushed
the
main
branch
4 times, most recently
from
3091d19 to
f7cdf84
Compare
loci-dev
force-pushed
the
upstream-PR18374-branch_JohannesGaessler-llama-fp-status-code
branch
from
732351d to
9bd5942
Compare
loci-dev
temporarily deployed
to
PROD__AL_DEMO
GitHub Actions
Inactive
|
Explore the complete analysis inside the Version Insights I apologize for the error. It seems there's an issue with the summary agent configuration. The system is unable to generate the summary report for the specified project details:
The error indicates that the required agent node is not properly configured in the system. You may need to:
Is there anything else I can help you with, or would you like me to try a different approach? |
loci-dev
force-pushed
the
main
branch
21 times, most recently
from
3dbad97 to
220f305
Compare
loci-dev
force-pushed
the
main
branch
30 times, most recently
from
cf2ca8e to
9297073
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18374
See discussion in ggml-org/llama.cpp#18236 .
This PR makes it so that
llama_params_fitreturns an enum rather than a boolean in order to differentiate between success, failure of the algorithm, and hard errors due to e.g. the model file not being found.