UPSTREAM PR #18236: cli: buffering info log, only show if model load failed#644
Closed
UPSTREAM PR #18236: cli: buffering info log, only show if model load failed#644
Conversation
7ceec3c to
c8dcfe6
Compare
26a6f0f to
cf53bc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18236
A QoL change that allow having more useful logs in case model loading failed.
Currently, the CLI uses ERROR as the default level, which make debugging quite tricky in some cases (in some cases INFO and WARN are also needed)
This PR introduce a "buffering" API to
common_logthat allows log lines to still be recorded, but can be dropped or flushed based on model load failed or success.The behavior:
CC @JohannesGaessler this can be useful for debugging problem with
-fit. Although I know DEBUG level is preferred, it can be quite difficult to copy-paste if the log is too verbose. WDYT?Demo loading a broken GGUF: