Skip to content

UPSTREAM PR #18147: webui: Add editing attachments in user messages#617

Open
loci-dev wants to merge 8 commits intomainfrom
upstream-PR18147-branch_allozaur-17206-allow-editing-attachments-in-past-user-messages
Open

UPSTREAM PR #18147: webui: Add editing attachments in user messages#617
loci-dev wants to merge 8 commits intomainfrom
upstream-PR18147-branch_allozaur-17206-allow-editing-attachments-in-past-user-messages

Conversation

@loci-dev
Copy link

Mirrored from ggml-org/llama.cpp#18147

Close #17206

  • Improved form UI component for editing user messages with options to choose model and attach files
  • Allow removing/adding files to edited message
  • Allow to update edited message without re-generating

Demo

demo.mp4

@loci-review
Copy link

loci-review bot commented Dec 18, 2025

Explore the complete analysis inside the Version Insights

Performance Analysis Summary

Project: llama.cpp
PR #617: webui: Add editing attachments in user messages
Scope: Frontend-only changes (14 files, +765/-241 lines)


Analysis Result

Condition 1 applies: No performance impact detected.

This PR modifies exclusively the web UI frontend components (Svelte/JavaScript) for the llama-server tool. No C/C++ source files in performance-critical areas were changed. The compressed build artifact index.html.gz update reflects frontend compilation only. All binaries show 0.0% power consumption change. No functions exhibit response time or throughput variations. The changes implement attachment editing functionality in the chat interface without touching inference pipelines, tokenization, or model execution paths.

@loci-dev loci-dev force-pushed the main branch 20 times, most recently from f002844 to 25154fc Compare December 21, 2025 21:07
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from f2e8c7f to b3f45e1 Compare December 29, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants