Skip to content

UPSTREAM PR #18003: CLI: fixed adding cli and completion into docker containers, improved docs#553

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18003-branch_andrew-aladev-feature/fix-devops-cli-and-completion-and-related-docs
Open

UPSTREAM PR #18003: CLI: fixed adding cli and completion into docker containers, improved docs#553
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18003-branch_andrew-aladev-feature/fix-devops-cli-and-completion-and-related-docs

Conversation

@loci-dev
Copy link

Mirrored from ggml-org/llama.cpp#18003

Hello @CISC I've read your PR #17964 and caught the idea: you've added both cli and completion into :light image. This is a good decision; we just need to improve this idea a bit:

  1. Add completion to llama-cli-cann.Dockerfile, llama-cpp-cuda.srpm.spec, and llama-cpp.srpm.spec.
  2. Add completion to nix/apps.nix.
  3. Replace main executables with clear executable lists in docs/docker.md.
  4. Add examples of using cli and completion in docs/docker.md.

Related PRs: #17964, #17824.

Please review; thank you.

@loci-dev loci-dev force-pushed the upstream-PR18003-branch_andrew-aladev-feature/fix-devops-cli-and-completion-and-related-docs branch from e67fdd7 to 6fc076e Compare December 13, 2025 19:33
@loci-review
Copy link

loci-review bot commented Dec 13, 2025

Explore the complete analysis inside the Version Insights

Performance Analysis Summary: PR #553

This PR contains DevOps and documentation changes only, with no modifications to source code in performance-critical areas. All changes affect Docker configurations, RPM specifications, and documentation files. Performance analysis confirms zero impact on runtime execution.

@loci-dev loci-dev force-pushed the main branch 25 times, most recently from 765e416 to 3c6cece Compare December 16, 2025 18:12
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from ac107ae to f002844 Compare December 21, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants