Skip to content

UPSTREAM PR #17991: arg: fix server router mode not accepting negated arg#549

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17991-branch_ngxson-xsn/arg_neg_fix
Open

UPSTREAM PR #17991: arg: fix server router mode not accepting negated arg#549
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17991-branch_ngxson-xsn/arg_neg_fix

Conversation

@loci-dev
Copy link

Mirrored from ggml-org/llama.cpp#17991

Missed a spot at the common_params_to_map used by router mode of server

Note: I'm also changing the overload common_params_parse to common_params_to_map to make it less confusing

Tested and working with llama-server --no-mmap

@loci-review
Copy link

loci-review bot commented Dec 13, 2025

Explore the complete analysis inside the Version Insights

Based on my analysis of PR #549 and the performance data, this pull request falls under Condition 1 (no meaningful performance changes).


Summary

PR #549 fixes argument parsing for negated arguments (e.g., --no-mmap) in server router mode by adding opt.args_neg to the argument-to-options mapping in common_params_to_map. The function was also renamed from common_params_parse for clarity. Performance analysis shows no impact: core inference functions (llama_decode, llama_encode, llama_tokenize) remain unchanged with 0 ns difference in throughput and response time. Power consumption is stable across all binaries. This is a correctness fix with no performance implications.

@loci-dev loci-dev force-pushed the main branch 26 times, most recently from 765e416 to 3c6cece Compare December 16, 2025 18:12
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from ac107ae to f002844 Compare December 21, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants