Skip to content

UPSTREAM PR #17949: cmake: link ws2_32 for MinGW/w64devkit builds in cpp-httplib#530

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17949-branch_gustrd-master
Open

UPSTREAM PR #17949: cmake: link ws2_32 for MinGW/w64devkit builds in cpp-httplib#530
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17949-branch_gustrd-master

Conversation

@loci-dev
Copy link

Mirrored from ggml-org/llama.cpp#17949

Small linker fix to allow the procedure described in build.md to work correctly using w64devkit.

Missing link found with Claude and corrected with Gemini.

@loci-review
Copy link

loci-review bot commented Dec 12, 2025

Explore the complete analysis inside the Version Insights

Performance Analysis Summary: PR #530

Analysis Scope: Build system modification for MinGW/w64devkit Windows builds
Change Type: CMake linker configuration
Files Modified: 1 (vendor/cpp-httplib/CMakeLists.txt)

This PR adds ws2_32 library linkage for MinGW Windows builds of cpp-httplib. The change is a build system fix with no source code modifications. Power consumption analysis shows 0.0% change across all binaries including libllama.so, llama-run, and libggml components. No function-level performance data indicates measurable differences between versions. The modification affects only HTTP server compilation and does not touch inference paths, tokenization logic, or GGML tensor operations. Functions responsible for inference performance (llama_decode, llama_encode, llama_tokenize) remain unchanged. No impact on tokens per second throughput.

@loci-dev loci-dev force-pushed the main branch 27 times, most recently from d1b57fc to d582acc Compare December 15, 2025 11:08
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from ec69147 to 883e4ba Compare December 19, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants