Skip to content

UPSTREAM PR #17903: docs: use port 8080 in Docker examples#509

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17903-branch_utsumi-fj-doc_docker_port
Open

UPSTREAM PR #17903: docs: use port 8080 in Docker examples#509
loci-dev wants to merge 1 commit intomainfrom
upstream-PR17903-branch_utsumi-fj-doc_docker_port

Conversation

@loci-dev
Copy link
Copy Markdown

Mirrored from ggml-org/llama.cpp#17903

Fixes #10262.

This PR fixes the documentation bug described in #10262, which was closed automatically by the stale bot.

The current Docker example:

docker run -v /path/to/models:/models \
  -p 8000:8000 \
  ghcr.io/ggml-org/llama.cpp:server \
  -m /models/7B/ggml-model-q4_0.gguf \
  --port 8000 \
  --host 0.0.0.0 \
  -n 512

causes the container health check to fail and the container status to become unhealthy.

The reason is that the example configures the server to listen on port 8000 (--port 8000), while the container image’s HEALTHCHECK is hard-coded to probe port 8080. This PR updates the documentation to use port 8080 so that the health check works correctly.

Signed-off-by: Yuichiro Utsumi <utsumi.yuichiro@fujitsu.com>
@loci-review
Copy link
Copy Markdown

loci-review bot commented Dec 10, 2025

Explore the complete analysis inside the Version Insights

Performance Analysis Summary: PR #509

This PR modifies only documentation (docs/docker.md), correcting Docker port examples from 8000 to 8080. No source code, binaries, or performance-critical functions were changed. Analysis confirms zero performance impact across all metrics.

@loci-dev loci-dev force-pushed the main branch 27 times, most recently from b28744d to 4733ac4 Compare December 13, 2025 12:13
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from 6c677ac to c39aef9 Compare December 18, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants