UPSTREAM PR #17903: docs: use port 8080 in Docker examples#509
Open
UPSTREAM PR #17903: docs: use port 8080 in Docker examples#509
Conversation
Signed-off-by: Yuichiro Utsumi <utsumi.yuichiro@fujitsu.com>
|
Explore the complete analysis inside the Version Insights Performance Analysis Summary: PR #509This PR modifies only documentation ( |
b28744d to
4733ac4
Compare
6c677ac to
c39aef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17903
Fixes #10262.
This PR fixes the documentation bug described in #10262, which was closed automatically by the stale bot.
The current Docker example:
causes the container health check to fail and the container status to become unhealthy.
The reason is that the example configures the server to listen on port 8000 (--port 8000), while the container image’s HEALTHCHECK is hard-coded to probe port 8080. This PR updates the documentation to use port 8080 so that the health check works correctly.