UPSTREAM PR #17755: common : skip model validation when --help is requested#429
Open
UPSTREAM PR #17755: common : skip model validation when --help is requested#429
Conversation
This commit skips the model validation check when the user specifies the --help option. The motivation for this is that currently and error is thrown before the --help could be processed. Now skips validation if params.usage is set, allowing help to display without requiring --model. Resolves: ggml-org/llama.cpp#17754
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
loci-dev
force-pushed
the
main
branch
28 times, most recently
from
7d0b0c3 to
e5edfa8
Compare
loci-dev
force-pushed
the
main
branch
30 times, most recently
from
4f731df to
8e6f6e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17755
This commit skips the model validation check when the user specifies the --help option.
The motivation for this is that currently and error is thrown before the --help could be processed. Now skips validation if params.usage is set, allowing help to display without requiring --model.
Resolves: ggml-org/llama.cpp#17754