UPSTREAM PR #17738: common: use native MultiByteToWideChar#420
UPSTREAM PR #17738: common: use native MultiByteToWideChar#420
Conversation
`std::codecvt_utf8<wchar_t>` is deprecated and produces warnings:
common/common.cpp:792:31: warning: 'codecvt_utf8<wchar_t>' is deprecated [-Wdeprecated-declarations]
792 | std::wstring_convert<std::codecvt_utf8<wchar_t>> converter;
|
Signed-off-by: Adrien Gallouët <[email protected]>
|
Explore the complete analysis inside the Version Insights Performance Analysis Summary: PR #420Analysis OverviewThis PR replaces deprecated Performance Impact AssessmentCondition 1 applies: No meaningful performance changes detected. The modified function handles directory creation during initialization and is not part of the inference or tokenization pipeline. Performance metrics for critical functions ( |
9612097 to
c217e38
Compare
1daebfe to
75a97fd
Compare
Mirrored from ggml-org/llama.cpp#17738
std::codecvt_utf8<wchar_t>is deprecated and produces warnings:Please, review carefully as I’ve used Gemini to generate
utf8_to_wstring()and I'm absolutely not a Windows dev.