Skip to content

UPSTREAM PR #17219: vulkan: remove shell call from vulkan-shaders-gen tool, revert file check#187

Closed
DajanaV wants to merge 1 commit intomainfrom
upstream-PR17219-branch_ggml-org-0cc4m/vulkan-shader-gen-no-shell
Closed

UPSTREAM PR #17219: vulkan: remove shell call from vulkan-shaders-gen tool, revert file check#187
DajanaV wants to merge 1 commit intomainfrom
upstream-PR17219-branch_ggml-org-0cc4m/vulkan-shader-gen-no-shell

Conversation

@DajanaV
Copy link
Copy Markdown
Collaborator

@DajanaV DajanaV commented Nov 12, 2025

Mirrored from ggml-org/llama.cpp#17219

This removes the shell invocation from the vulkan-shaders-gen tool, and instead splits the string and feeds separate arguments into execvp. This way, no shell is needed. I also removed the file check on glslc.

@MaggotHATE Please check if this works for you.

@DajanaV DajanaV force-pushed the main branch 9 times, most recently from 24733fb to 4b4bb7c Compare November 13, 2025 12:15
@DajanaV DajanaV closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants