UPSTREAM PR #19254: Add test for vk_buffer from host memory#1126
Open
UPSTREAM PR #19254: Add test for vk_buffer from host memory#1126
Conversation
loci-dev
temporarily deployed
to
PROD__AL_DEMO
GitHub Actions
Inactive
|
No meaningful performance changes were detected across 115327 analyzed functions in the following binaries: build.bin.libllama.so, build.bin.llama-tts, build.bin.llama-cvector-generator, build.bin.libmtmd.so, build.bin.libggml-base.so, build.bin.libggml-cpu.so, build.bin.libggml.so, build.bin.llama-gguf-split, build.bin.llama-llava-cli, build.bin.llama-minicpmv-cli, build.bin.llama-quantize, build.bin.llama-gemma3-cli, build.bin.llama-bench, build.bin.llama-tokenize, build.bin.llama-qwen2vl-cli. 🔎 Full breakdown: Loci Inspector. |
loci-dev
force-pushed
the
main
branch
26 times, most recently
from
6efe498 to
8db062d
Compare
loci-dev
force-pushed
the
main
branch
11 times, most recently
from
4a5a4c2 to
45aacad
Compare
loci-dev
force-pushed
the
main
branch
8 times, most recently
from
13648e6 to
1d064d0
Compare
loci-dev
force-pushed
the
main
branch
8 times, most recently
from
551dfb5 to
55a969e
Compare
loci-dev
force-pushed
the
main
branch
3 times, most recently
from
61601b2 to
56aaa36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#19254
Add a test to validate external host memory can correctly be allocated, written, used, and read.
I already had this test for my own external memory buffer solution, but then I noticed #18467 had done the work. I thought the test might still be useful.