Fix contact sales form: add SMTP email notifications on inquiry submission by Copilot · Pull Request #435 · aurelianware/cloudhealthoffice

Copilot · 2026-03-05T02:50:56Z

SalesInquiryService.CreateInquiryAsync() was only persisting inquiries to MongoDB — no email was ever sent to the sales team or the submitter.

What changed

IEmailNotificationService — new interface with SendSalesInquiryNotificationAsync(SalesInquiry)
SmtpEmailNotificationService — new implementation using System.Net.Mail (no new dependencies):
- Sends internal alert to sales@cloudhealthoffice.com with full inquiry details; Reply-To set to submitter
- Sends confirmation to submitter with reference ID and SLA
- Each send is independently wrapped in try/catch — one failure does not block the other
- Validates submitter email via MailAddress before construction
- Gracefully no-ops (with a warning log) when Email:SmtpHost is unconfigured, preserving behavior on existing deployments
SalesInquiryService — injects IEmailNotificationService, calls it after a successful DB write

appsettings.json — adds Email config block; activate via Kubernetes secrets:

Email__SmtpHost, Email__Username, Email__Password
# optional: Email__SmtpPort, Email__EnableSsl, Email__FromAddress, Email__SalesTeamAddress

Program.cs — registers SmtpEmailNotificationService as singleton

Original prompt

tps://portal.cloudhealthoffice.com/contact-sales does the contact sales page send an email or is it saved somewhere? I just tested it and did not receive an email.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Add IEmailNotificationService interface and SmtpEmailNotificationService implementation - Update SalesInquiryService to call email service after saving inquiry to DB - Register SmtpEmailNotificationService as singleton in Program.cs - Add Email SMTP config section to appsettings.json - Add 3 unit tests for SmtpEmailNotificationService Co-authored-by: aurelianware <194855645+aurelianware@users.noreply.github.com>

github-actions · 2026-03-05T03:12:24Z

Package	Line Rate	Branch Rate	Health
CloudHealthOffice.Portal	3%	4%	❌
CloudHealthOffice.Portal	3%	4%	❌
Summary	3% (390 / 11876)	4% (96 / 2452)	❌

aurelianware · 2026-03-05T03:15:05Z

@colilot do I need to configure a mail account to send from?

Copilot

Pull request overview

Adds SMTP-based email notifications for the Portal’s “Contact Sales” flow so that creating a sales inquiry triggers (1) an internal alert to the sales team and (2) a confirmation email to the submitter, while keeping existing behavior when SMTP isn’t configured.

Changes:

Introduces IEmailNotificationService and an SMTP-backed implementation (SmtpEmailNotificationService) to send sales inquiry notifications.
Updates SalesInquiryService.CreateInquiryAsync() to send notifications after successfully persisting the inquiry to MongoDB.
Adds Email configuration defaults and registers the new email service in DI; includes unit tests for basic failure/no-config behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/portal/CloudHealthOffice.Portal/appsettings.json	Adds `Email` configuration block (SMTP host/port/SSL/from/sales team creds).
src/portal/CloudHealthOffice.Portal/Services/ServiceImplementations.cs	Injects email notifications into inquiry creation and adds `SmtpEmailNotificationService` implementation.
src/portal/CloudHealthOffice.Portal/Services/IServices.cs	Adds `IEmailNotificationService` interface.
src/portal/CloudHealthOffice.Portal/Program.cs	Registers `SmtpEmailNotificationService` as the `IEmailNotificationService` implementation.
src/portal/CloudHealthOffice.Portal.Tests/Services/SmtpEmailNotificationServiceTests.cs	Adds tests for “SMTP not configured” and “SMTP failure doesn’t throw” scenarios.

Copilot · 2026-03-05T05:08:32Z

src/portal/CloudHealthOffice.Portal/Services/ServiceImplementations.cs

+        var smtpPort = int.TryParse(_configuration["Email:SmtpPort"], out var port) ? port : 587;
+        var enableSsl = !string.Equals(_configuration["Email:EnableSsl"], "false", StringComparison.OrdinalIgnoreCase);
+        var fromAddress = _configuration["Email:FromAddress"] ?? "noreply@cloudhealthoffice.com";
+        var salesTeamAddress = _configuration["Email:SalesTeamAddress"] ?? "sales@cloudhealthoffice.com";
+        var username = _configuration["Email:Username"];
+        var password = _configuration["Email:Password"];
+
+        using var client = new SmtpClient(smtpHost, smtpPort)
+        {
+            EnableSsl = enableSsl,
+            Credentials = !string.IsNullOrWhiteSpace(username)
+                ? new NetworkCredential(username, password)
+                : CredentialCache.DefaultNetworkCredentials
+        };
+
+        try
+        {
+            using var salesNotification = BuildSalesTeamEmail(fromAddress, salesTeamAddress, inquiry);
+            await client.SendMailAsync(salesNotification);
+            _logger.LogInformation("Sales team notification sent for inquiry {InquiryId}", inquiry.Id);
+        }
+        catch (Exception ex)
+        {
+            _logger.LogError(ex, "Failed to send sales team notification for inquiry {InquiryId}", inquiry.Id);
+            // Do not rethrow — email failure must not prevent a successful inquiry submission
+        }
+
+        if (!string.IsNullOrWhiteSpace(inquiry.Email) && IsValidEmail(inquiry.Email))
+        {
+            try
+            {
+                using var confirmation = BuildConfirmationEmail(fromAddress, inquiry);
+                await client.SendMailAsync(confirmation);
+                _logger.LogInformation("Confirmation email sent to {Email} for inquiry {InquiryId}", inquiry.Email, inquiry.Id);
+            }
+            catch (Exception ex)
+            {
+                _logger.LogError(ex, "Failed to send confirmation email to {Email} for inquiry {InquiryId}", inquiry.Email, inquiry.Id);
+                // Do not rethrow — confirmation email failure must not prevent a successful inquiry submission
+            }
+        }


smtpPort parsing accepts any int; invalid values (e.g., -1 or > 65535) will cause SmtpClient construction to throw and bubble up. Clamp/validate the range and default to 587 on invalid values, or wrap the client construction in a try/catch so misconfiguration can’t break inquiry submission.

Suggested change

var smtpPort = int.TryParse(_configuration["Email:SmtpPort"], out var port) ? port : 587;

var enableSsl = !string.Equals(_configuration["Email:EnableSsl"], "false", StringComparison.OrdinalIgnoreCase);

var fromAddress = _configuration["Email:FromAddress"] ?? "noreply@cloudhealthoffice.com";

var salesTeamAddress = _configuration["Email:SalesTeamAddress"] ?? "sales@cloudhealthoffice.com";

var username = _configuration["Email:Username"];

var password = _configuration["Email:Password"];

using var client = new SmtpClient(smtpHost, smtpPort)

{

EnableSsl = enableSsl,

Credentials = !string.IsNullOrWhiteSpace(username)

? new NetworkCredential(username, password)

: CredentialCache.DefaultNetworkCredentials

};

try

{

using var salesNotification = BuildSalesTeamEmail(fromAddress, salesTeamAddress, inquiry);

await client.SendMailAsync(salesNotification);

_logger.LogInformation("Sales team notification sent for inquiry {InquiryId}", inquiry.Id);

}

catch (Exception ex)

{

_logger.LogError(ex, "Failed to send sales team notification for inquiry {InquiryId}", inquiry.Id);

// Do not rethrow — email failure must not prevent a successful inquiry submission

}

if (!string.IsNullOrWhiteSpace(inquiry.Email) && IsValidEmail(inquiry.Email))

{

try

{

using var confirmation = BuildConfirmationEmail(fromAddress, inquiry);

await client.SendMailAsync(confirmation);

_logger.LogInformation("Confirmation email sent to {Email} for inquiry {InquiryId}", inquiry.Email, inquiry.Id);

}

catch (Exception ex)

{

_logger.LogError(ex, "Failed to send confirmation email to {Email} for inquiry {InquiryId}", inquiry.Email, inquiry.Id);

// Do not rethrow — confirmation email failure must not prevent a successful inquiry submission

}

}

var smtpPortConfig = _configuration["Email:SmtpPort"];

int smtpPort;

if (!int.TryParse(smtpPortConfig, out smtpPort) || smtpPort <= 0 || smtpPort > 65535)

{

_logger.LogWarning("Invalid SMTP port configuration value '{SmtpPort}'. Defaulting to 587.", smtpPortConfig);

smtpPort = 587;

}

var enableSsl = !string.Equals(_configuration["Email:EnableSsl"], "false", StringComparison.OrdinalIgnoreCase);

var fromAddress = _configuration["Email:FromAddress"] ?? "noreply@cloudhealthoffice.com";

var salesTeamAddress = _configuration["Email:SalesTeamAddress"] ?? "sales@cloudhealthoffice.com";

var username = _configuration["Email:Username"];

var password = _configuration["Email:Password"];

try

{

using var client = new SmtpClient(smtpHost, smtpPort)

{

EnableSsl = enableSsl,

Credentials = !string.IsNullOrWhiteSpace(username)

? new NetworkCredential(username, password)

: CredentialCache.DefaultNetworkCredentials

};

try

{

using var salesNotification = BuildSalesTeamEmail(fromAddress, salesTeamAddress, inquiry);

await client.SendMailAsync(salesNotification);

_logger.LogInformation("Sales team notification sent for inquiry {InquiryId}", inquiry.Id);

}

catch (Exception ex)

{

_logger.LogError(ex, "Failed to send sales team notification for inquiry {InquiryId}", inquiry.Id);

// Do not rethrow — email failure must not prevent a successful inquiry submission

}

if (!string.IsNullOrWhiteSpace(inquiry.Email) && IsValidEmail(inquiry.Email))

{

try

{

using var confirmation = BuildConfirmationEmail(fromAddress, inquiry);

await client.SendMailAsync(confirmation);

_logger.LogInformation("Confirmation email sent to {Email} for inquiry {InquiryId}", inquiry.Email, inquiry.Id);

}

catch (Exception ex)

{

_logger.LogError(ex, "Failed to send confirmation email to {Email} for inquiry {InquiryId}", inquiry.Email, inquiry.Id);

// Do not rethrow — confirmation email failure must not prevent a successful inquiry submission

}

}

}

catch (Exception ex)

{

_logger.LogError(ex, "Failed to initialize SMTP client for inquiry {InquiryId}", inquiry.Id);

// Do not rethrow — email failure (including client initialization) must not prevent a successful inquiry submission

}

Copilot · 2026-03-05T05:08:33Z

src/portal/CloudHealthOffice.Portal/Services/ServiceImplementations.cs


            _logger.LogInformation("Successfully created sales inquiry {InquiryId}", inquiryId);
+
+            await _emailNotificationService.SendSalesInquiryNotificationAsync(inquiry);


CreateInquiryAsync awaits SendSalesInquiryNotificationAsync inside the main try/catch; if email sending throws (e.g., due to SMTP port misconfiguration) the method will rethrow even though the inquiry was already inserted, leading the UI to show a failure while the inquiry actually exists. Wrap the notification call in its own try/catch and always return inquiryId after a successful DB insert.

Suggested change

await _emailNotificationService.SendSalesInquiryNotificationAsync(inquiry);

try

{

await _emailNotificationService.SendSalesInquiryNotificationAsync(inquiry);

}

catch (Exception notificationEx)

{

_logger.LogError(notificationEx,

"Failed to send sales inquiry notification for {InquiryId}", inquiryId);

}

Copilot · 2026-03-05T05:08:33Z

src/portal/CloudHealthOffice.Portal.Tests/Services/SmtpEmailNotificationServiceTests.cs

+    public async Task SendSalesInquiryNotificationAsync_WhenSmtpFails_DoesNotThrow()
+    {
+        // Arrange — point at a non-existent SMTP server to force a send failure
+        var config = BuildConfiguration(new Dictionary<string, string?>
+        {
+            ["Email:SmtpHost"] = "smtp.invalid.example.test",
+            ["Email:SmtpPort"] = "587",
+            ["Email:EnableSsl"] = "false",
+            ["Email:FromAddress"] = "noreply@cloudhealthoffice.com",
+            ["Email:SalesTeamAddress"] = "sales@cloudhealthoffice.com"
+        });
+        var sut = new SmtpEmailNotificationService(config, _logger.Object);
+
+        // Act
+        var exception = await Record.ExceptionAsync(() =>
+            sut.SendSalesInquiryNotificationAsync(BuildSampleInquiry()));
+


This test forces SMTP failure by calling a real host name; depending on DNS/network conditions, SendMailAsync can take a long time (default SmtpClient timeout is ~100s) and make CI flaky. Prefer a deterministic failure (e.g., localhost with a closed port) and/or add a configurable SmtpClient timeout so tests can set it low.

Copilot · 2026-03-05T05:08:33Z

src/portal/CloudHealthOffice.Portal/Services/ServiceImplementations.cs

+            Body = body,
+            IsBodyHtml = false
+        };
+        message.ReplyToList.Add(new MailAddress(inquiry.Email, $"{inquiry.FirstName} {inquiry.LastName}"));


BuildSalesTeamEmail always adds a Reply-To using inquiry.Email. When the submitter email is empty/invalid (which you already detect earlier), this MailAddress construction will throw and the internal sales-team notification will fail. Only add Reply-To when the submitter email is valid (or omit Reply-To entirely when invalid) so the sales team still receives the inquiry.

Suggested change

message.ReplyToList.Add(new MailAddress(inquiry.Email, $"{inquiry.FirstName} {inquiry.LastName}"));

if (!string.IsNullOrWhiteSpace(inquiry.Email) && IsValidEmail(inquiry.Email))

{

message.ReplyToList.Add(new MailAddress(inquiry.Email, $"{inquiry.FirstName} {inquiry.LastName}"));

}

Copilot · 2026-03-05T05:08:33Z

src/portal/CloudHealthOffice.Portal/Services/ServiceImplementations.cs

+        var fromAddress = _configuration["Email:FromAddress"] ?? "noreply@cloudhealthoffice.com";
+        var salesTeamAddress = _configuration["Email:SalesTeamAddress"] ?? "sales@cloudhealthoffice.com";


Email:FromAddress and Email:SalesTeamAddress fall back only when the config value is null, but configuration can provide an empty string. Treat whitespace/empty values as “not configured” (or validate addresses) to avoid MailMessage throwing and silently dropping notifications.

Suggested change

var fromAddress = _configuration["Email:FromAddress"] ?? "noreply@cloudhealthoffice.com";

var salesTeamAddress = _configuration["Email:SalesTeamAddress"] ?? "sales@cloudhealthoffice.com";

var configuredFromAddress = _configuration["Email:FromAddress"];

var fromAddress = !string.IsNullOrWhiteSpace(configuredFromAddress) && IsValidEmail(configuredFromAddress)

? configuredFromAddress

: "noreply@cloudhealthoffice.com";

if (!string.IsNullOrWhiteSpace(configuredFromAddress) && !IsValidEmail(configuredFromAddress))

{

_logger.LogWarning("Configured From address '{FromAddress}' is invalid. Falling back to default noreply address.", configuredFromAddress);

}

var configuredSalesTeamAddress = _configuration["Email:SalesTeamAddress"];

var salesTeamAddress = !string.IsNullOrWhiteSpace(configuredSalesTeamAddress) && IsValidEmail(configuredSalesTeamAddress)

? configuredSalesTeamAddress

: "sales@cloudhealthoffice.com";

if (!string.IsNullOrWhiteSpace(configuredSalesTeamAddress) && !IsValidEmail(configuredSalesTeamAddress))

{

_logger.LogWarning("Configured Sales Team address '{SalesTeamAddress}' is invalid. Falling back to default sales address.", configuredSalesTeamAddress);

}

Copilot AI self-assigned this Mar 5, 2026

Initial plan

1122831

Copilot AI assigned aurelianware Mar 5, 2026

Copilot started work on behalf of aurelianware March 5, 2026 02:51 View session

Copilot AI changed the title ~~[WIP] Fix email sending issue on contact sales page~~ Fix contact sales form: add SMTP email notifications on inquiry submission Mar 5, 2026

Copilot finished work on behalf of aurelianware March 5, 2026 03:00

github-actions bot added github-config size/M labels Mar 5, 2026

aurelianware marked this pull request as ready for review March 5, 2026 05:03

Copilot AI review requested due to automatic review settings March 5, 2026 05:03

Copilot started reviewing on behalf of aurelianware March 5, 2026 05:04 View session

aurelianware merged commit 4058ab7 into main Mar 5, 2026
64 checks passed

aurelianware deleted the copilot/fix-contact-sales-email-issue branch March 5, 2026 05:07

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix contact sales form: add SMTP email notifications on inquiry submission#435

Fix contact sales form: add SMTP email notifications on inquiry submission#435
aurelianware merged 2 commits intomainfrom
copilot/fix-contact-sales-email-issue

Copilot AI commented Mar 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

aurelianware commented Mar 5, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Copilot AI Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		_logger.LogInformation("Successfully created sales inquiry {InquiryId}", inquiryId);

		await _emailNotificationService.SendSalesInquiryNotificationAsync(inquiry);

-            await _emailNotificationService.SendSalesInquiryNotificationAsync(inquiry);
+            try
+            {
+                await _emailNotificationService.SendSalesInquiryNotificationAsync(inquiry);
+            }
+            catch (Exception notificationEx)
+            {
+                _logger.LogError(notificationEx,
+                    "Failed to send sales inquiry notification for {InquiryId}", inquiryId);
+            }

		var fromAddress = _configuration["Email:FromAddress"] ?? "noreply@cloudhealthoffice.com";
		var salesTeamAddress = _configuration["Email:SalesTeamAddress"] ?? "sales@cloudhealthoffice.com";

-        var fromAddress = _configuration["Email:FromAddress"] ?? "noreply@cloudhealthoffice.com";
-        var salesTeamAddress = _configuration["Email:SalesTeamAddress"] ?? "sales@cloudhealthoffice.com";
+        var configuredFromAddress = _configuration["Email:FromAddress"];
+        var fromAddress = !string.IsNullOrWhiteSpace(configuredFromAddress) && IsValidEmail(configuredFromAddress)
+            ? configuredFromAddress
+            : "noreply@cloudhealthoffice.com";
+        if (!string.IsNullOrWhiteSpace(configuredFromAddress) && !IsValidEmail(configuredFromAddress))
+        {
+            _logger.LogWarning("Configured From address '{FromAddress}' is invalid. Falling back to default noreply address.", configuredFromAddress);
+        }
+        var configuredSalesTeamAddress = _configuration["Email:SalesTeamAddress"];
+        var salesTeamAddress = !string.IsNullOrWhiteSpace(configuredSalesTeamAddress) && IsValidEmail(configuredSalesTeamAddress)
+            ? configuredSalesTeamAddress
+            : "sales@cloudhealthoffice.com";
+        if (!string.IsNullOrWhiteSpace(configuredSalesTeamAddress) && !IsValidEmail(configuredSalesTeamAddress))
+        {
+            _logger.LogWarning("Configured Sales Team address '{SalesTeamAddress}' is invalid. Falling back to default sales address.", configuredSalesTeamAddress);
+        }

Uh oh!

Conversation

Copilot AI commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

aurelianware commented Mar 5, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 5, 2026 •

edited

Loading