Skip to content

Added a closing tag to the let elements#647

Merged
EisenbergEffect merged 1 commit intoaurelia:masterfrom
tomschluter:closing-tag-let-elements
Oct 8, 2018
Merged

Added a closing tag to the let elements#647
EisenbergEffect merged 1 commit intoaurelia:masterfrom
tomschluter:closing-tag-let-elements

Conversation

@tomschluter
Copy link
Contributor

@tomschluter tomschluter commented Oct 8, 2018

It appears that the examples of the usage of the let element don't seem to work without a closing tag. Unfortunately a self closing tag doesn't seem to work either. So I have added closing tags to the let elements for now.

It appears that the examples of the usage of the let element don't seem work without a closing tag. Unfortunately a self closing tag doesn't seem to work either. So I have added closing tags to the let elements for now.
@3cp
Copy link
Member

3cp commented Oct 8, 2018

Note self-closing is xml syntax, not HTML5 syntax.

In HTML5, <any-tag /> is treated as <any-tag>, the / is ignored totally. HTML5 only defined few tags without need of closing like <input>, <br>, <hr>, <img>, <embed>, <col>, <param>, <source>, <track> and in html head <meta>, <base>, <link>. I might missed some.

When you write <input /> in HTML5, it still works because HTML5 sees it as <input>. This is the same reason why <let /> didn't work as intended.

@bigopon
Copy link
Member

bigopon commented Oct 8, 2018

Thanks @tomschluter @huochunpeng.
Lgtm @EisenbergEffect. Sry i missed this

@3cp
Copy link
Member

3cp commented Oct 8, 2018

@bigopon note not only the <let> is incorrect, the <input> also get unnecessary /> ending which is bad example of HTML5. The blog post is affected too.

@tomschluter do you mind to clean up all <input> tags too in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants