feat(client): update AWS secrets env var handling checks #2501
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to use AWS env vars as documented, replace duplicated entries AWS_SECRET_ACCESS_KEY the secret paired to Access Key IDs AWS_SESSION_TOKEN the secret session token for STS sessions
Contributor
Author
|
With the v18.4 these secrets appear in the history
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use AWS env vars, replace duplicated entries.
AWS_SECRET_ACCESS_KEYthe secret paired to Access Key IDsAWS_SESSION_TOKENthe secret session token for STS sessionsAWS Access Keys should be caught by the test above for
"AKIA[0-9A-Z]{16}"though this might also be updated to use a matching format with these two entries (including the env var name).Relates to #2174
AWS documentation: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html
Checks